Fix missing docker builder failure#588
Draft
JenniferBuehler wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
this goes on top of #587 so will include those changes. Therefore, it's still in draft.
Add the
docker buildx createstep tobuild_container.shso that skill building on a fresh system (where that wasn't run) doesn't fail.To reproduce, on a fresh system setup (from the
phase_1branch), try to build a skill, e.g.:Then observe:
build_aic_flowstate_skills.shfails withERROR: no builder "container-builder" found, followed by a misleading cascade of errors (open ./images/…/.tar: no such file, pull access denied for aic_flowstate_skills, and more).Reason:
build_container.shrunsdocker buildx build --builder=container-builderbut neither it nor the docs create that builder (side note:intrinsic_sdk_build/build.pydoes create it).After running
docker buildx create --name container-builder --driver docker-container, it works.This PR adds this step to the
build_container.shso it doesn't have to be run manually. With this branchpixi run --manifest-path src/aic/pixi.toml bash src/aic/flowstate/scripts/build_aic_flowstate_skills.sh --skill_name tare_force_torque_sensor_skillpasses on a fresh setup. Also prevents the "misleading cascade of errors" by settingset -eo pipefail.