fix(css): add missing closing brace that broke esbuild CSS compilation#3418
Merged
Merged
Conversation
github-actions
Bot
added
desktop
SivanCola
approved these changes
Jun 7, 2026
SivanCola
left a comment
SivanCola
left a comment
Collaborator
There was a problem hiding this comment.
Approved. This is a well-scoped CSS syntax fix.
The missing closing brace is real: the base stylesheet leaves .onboarding__skip:disabled open, and this patch balances the rule so the following InlineDiff, dock, and context inspector styles are parsed normally again. I also checked the integration path against the latest main-v2; the no-commit merge was clean.
Security/cache review: this only changes one CSS rule terminator, with no dependency, runtime privilege, provider request, prompt-prefix, tool schema, or serialization impact.
Verified:
git diff --checkpassedcd desktop && wails generate module && pnpm --dir frontend buildpassed- Built CSS contains the downstream
.workbench-dock/.context-inspectorlayout selectors
The .onboarding__skip:disabled block was missing its closing '}', causing esbuild (used by Vite dev mode) to abort CSS parsing at line 7049. All rules after line 7049 — including .workbench-dock layout positioning — were silently discarded, breaking the right-side dock layout. Introduced as a merge conflict artefact between esengine#2752 (onboarding) and esengine#3129 (InlineDiff component).
CVEngineer66
force-pushed
the
fix/css-missing-brace
branch
from
271907a to
cffa369
Compare
CVEngineer66
pushed a commit
to CVEngineer66/DeepSeek-Reasonix
that referenced
this pull request
Jun 7, 2026
Same root cause as PR esengine#3418 — the .onboarding__skip:disabled block was missing its closing '}', causing check-css-syntax.mjs to fail.
CVEngineer66
pushed a commit
to CVEngineer66/DeepSeek-Reasonix
that referenced
this pull request
Jun 7, 2026
…tream bug) Same root cause as PR esengine#3418 — the .onboarding__skip:disabled block was missing its closing '}' in upstream/main-v2, causing check-css-syntax.mjs to fail on any branch based on upstream.
CVEngineer66
pushed a commit
to CVEngineer66/DeepSeek-Reasonix
that referenced
this pull request
Jun 7, 2026
A second merged conflict artefact from esengine#2752 (onboarding) and esengine#3129 (InlineDiff) left an unclosed block at line 7082. Same root cause as PR esengine#3418 but at a different offset. The check-css-syntax.mjs script (PR esengine#3420) now catches this, but upstream itself is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.onboarding__skip:disabledblock was missing its closing}, causing esbuild (Vite dev mode CSS compiler) to abort at line 7049. All rules after that point — ~1900 lines including.workbench-dock,.context-panel,.context-inspectorlayout positioning — were silently discarded, breaking the right-side dock layout.Introduced as a merge conflict artefact between #2752 (onboarding overlay) and #3129 (InlineDiff component).
Verification:
pnpm build— no moreExpected "}" to go with "{"warning.context-inspector,.workbench-dock{grid-row:2;grid-column:4;...}