Summary
desktop/frontend/src/styles.css line 7082 has an unclosed .onboarding__skip:disabled block (missing closing }). This causes all PRs based on main-v2 to fail the desktop CI check introduced by PR #3420 (which runs node scripts/check-css-syntax.mjs src/styles.css as part of the build).
Root cause
A merge conflict artefact between PR #2752 (feat(desktop): first-run onboarding overlay for default provider API key) and PR #3129 (feat(desktop): InlineDiff component for compact before/after tool results) left two unclosed .onboarding__skip:disabled blocks in styles.css:
| Line |
Status |
| :7048 |
✅ Fixed by PR #3418 (merged) |
| :7082 |
❌ Still open — this issue |
The first one at line 7048 was reported and fixed in PR #3418. But a second identical artefact at line 7082, ~30 lines below, went unnoticed because the CSS syntax check script (check-css-syntax.mjs) was not yet added to CI at that point. It was only discovered when PR #3420 added the check and every subsequent PR started failing.
Impact
- Every open PR based on
main-v2 fails the desktop CI check
- Not limited to any specific contributor or feature
- The
lint, test, race, and coverage checks pass fine — only desktop is affected
- Local
pnpm build also fails if run via the full script (check-css-syntax.mjs → tsc → vite)
Affected file
desktop/frontend/src/styles.css line 7082:
.onboarding__skip:disabled {
opacity: 0.4;
cursor: not-allowed;
/* ← missing } */
}
Fix
.onboarding__skip:disabled {
opacity: 0.4;
cursor: not-allowed;
-
+}
Verification
cd desktop/frontend && node scripts/check-css-syntax.mjs src/styles.css
# Expected: "CSS syntax check passed: src/styles.css"
Related
Summary
desktop/frontend/src/styles.cssline 7082 has an unclosed.onboarding__skip:disabledblock (missing closing}). This causes all PRs based onmain-v2to fail thedesktopCI check introduced by PR #3420 (which runsnode scripts/check-css-syntax.mjs src/styles.cssas part of the build).Root cause
A merge conflict artefact between PR #2752 (
feat(desktop): first-run onboarding overlay for default provider API key) and PR #3129 (feat(desktop): InlineDiff component for compact before/after tool results) left two unclosed.onboarding__skip:disabledblocks instyles.css:The first one at line 7048 was reported and fixed in PR #3418. But a second identical artefact at line 7082, ~30 lines below, went unnoticed because the CSS syntax check script (
check-css-syntax.mjs) was not yet added to CI at that point. It was only discovered when PR #3420 added the check and every subsequent PR started failing.Impact
main-v2fails thedesktopCI checklint,test,race, andcoveragechecks pass fine — onlydesktopis affectedpnpm buildalso fails if run via the full script (check-css-syntax.mjs→tsc→vite)Affected file
desktop/frontend/src/styles.cssline 7082:Fix
.onboarding__skip:disabled { opacity: 0.4; cursor: not-allowed; - +}Verification
Related
check-css-syntax.mjsto CI, which exposed this second instance