Skip to content

upstream styles.css has an unclosed block breaking all PR desktop CI #3435

@CVEngineer66

Description

@CVEngineer66

Summary

desktop/frontend/src/styles.css line 7082 has an unclosed .onboarding__skip:disabled block (missing closing }). This causes all PRs based on main-v2 to fail the desktop CI check introduced by PR #3420 (which runs node scripts/check-css-syntax.mjs src/styles.css as part of the build).

Root cause

A merge conflict artefact between PR #2752 (feat(desktop): first-run onboarding overlay for default provider API key) and PR #3129 (feat(desktop): InlineDiff component for compact before/after tool results) left two unclosed .onboarding__skip:disabled blocks in styles.css:

Line Status
:7048 ✅ Fixed by PR #3418 (merged)
:7082 Still open — this issue

The first one at line 7048 was reported and fixed in PR #3418. But a second identical artefact at line 7082, ~30 lines below, went unnoticed because the CSS syntax check script (check-css-syntax.mjs) was not yet added to CI at that point. It was only discovered when PR #3420 added the check and every subsequent PR started failing.

Impact

  • Every open PR based on main-v2 fails the desktop CI check
  • Not limited to any specific contributor or feature
  • The lint, test, race, and coverage checks pass fine — only desktop is affected
  • Local pnpm build also fails if run via the full script (check-css-syntax.mjstscvite)

Affected file

desktop/frontend/src/styles.css line 7082:

.onboarding__skip:disabled {
  opacity: 0.4;
  cursor: not-allowed;
                                        /* ← missing } */
}

Fix

 .onboarding__skip:disabled {
   opacity: 0.4;
   cursor: not-allowed;
-
+}

Verification

cd desktop/frontend && node scripts/check-css-syntax.mjs src/styles.css
# Expected: "CSS syntax check passed: src/styles.css"

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    desktopWails desktop app (desktop/**)

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions