fix(css): add missing closing brace in onboarding__skip:disabled (take 2)#3431
Closed
CVEngineer66 wants to merge 1 commit into
Closed
fix(css): add missing closing brace in onboarding__skip:disabled (take 2)#3431CVEngineer66 wants to merge 1 commit into
CVEngineer66 wants to merge 1 commit into
Conversation
A second merged conflict artefact from esengine#2752 (onboarding) and esengine#3129 (InlineDiff) left an unclosed block at line 7082. Same root cause as PR esengine#3418 but at a different offset. The check-css-syntax.mjs script (PR esengine#3420) now catches this, but upstream itself is affected.
github-actions
Bot
added
desktop
Contributor
Author
|
Duplicate of #3434 which was merged first — same CSS fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same root cause as PR #3418 — a merge conflict artefact between #2752 (onboarding overlay) and #3129 (InlineDiff component) left a second unclosed
.onboarding__skip:disabledblock at line 7082, about 30 lines below the first one.The
check-css-syntax.mjsscript (added by PR #3420) now catches this in CI, which means every PR based onmain-v2was failing thedesktopcheck until this is merged upstream.Verification:
node scripts/check-css-syntax.mjs src/styles.css— ✅ passedpnpm build— ✅ passed