Fix #1370: Correct ownership check for remittances - #1578
Merged
Conversation
6 tasks
ogazboiz
approved these changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
excellent find, both ownership checks in remittanceController were tautologies (senderAddress !== senderAddress) so any authenticated user could read or submit any remittance. verified senderId is populated from req.user.publicKey at creation, so the address comparison is sound. merging as a priority authz fix. a follow-up 403 cross-user test would be welcome (see the coverage in #1444 for inspiration).
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fixes #1370.
A critical vulnerability in backend/src/controllers/remittanceController.ts allowed any authenticated user to submit another user's pending remittance. The ownership validation was incorrectly comparing a value to itself (remittance.senderId !== remittance.senderId and senderAddress !== senderAddress).
This PR corrects the logic in both submitRemittanceTransaction and getRemittance to securely compare the remittance's sender ID against the authenticated sender's wallet address (remittance.senderId !== senderAddress).