Skip to content

[Backend] Any user can submit another user's pending remittance #1370

Description

@ogazboiz

Questions or want to claim this? Say hi in the community chat: https://t.me/+DOylgFv1jyJlNzM0

Description

The ownership check compares a value to itself rather than to the authenticated sender, so a pending remittance can be submitted by anyone.

Component: Backend
Location: backend/src/controllers/remittanceController.ts -> submitRemittanceTransaction
Severity: Critical

How to reproduce / find it

Submit a pending remittance created by a different user.

Expected behavior

Only the remittance's sender should be able to submit it.

Notes for contributors

This is a logic/behavior defect, not a compile error. Please open one PR per fix that references this issue and names the file and function above.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Stellar WaveIssues in the Stellar wave programbackendIssues related to backend developmentbugSomething isn't workingcriticalHigh-impact / hard issuesecuritySecurity related issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions