Skip to content

Fix #1370: Correct ownership check for remittances #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogazboiz merged 2 commits into from
Aug 3, 2026
Merged

Fix #1370: Correct ownership check for remittances #1578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c1c53
Fix #1370: Correct ownership check for remittances
T-kesh Aug 1, 2026
024f198
Merge branch 'main' into fix-issue-1370
ogazboiz Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/controllers/remittanceController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export const getRemittance = asyncHandler(async (req: Request, res: Response) =>
const remittance = await remittanceService.getRemittance(id);

// Verify the user owns this remittance
if (senderAddress !== senderAddress) {
if (remittance.senderId !== senderAddress) {
throw AppError.forbidden('You do not have access to this remittance');
}

Expand Down Expand Up @@ -242,7 +242,7 @@ export const submitRemittanceTransaction = asyncHandler(async (req: Request, res
try {
const remittance = await remittanceService.getRemittance(id);

if (remittance.senderId !== remittance.senderId) {
if (remittance.senderId !== senderAddress) {
throw AppError.forbidden('You do not have access to this remittance');
}

Expand Down
Loading