Skip to content

fix(kpi): restack fatal UTF-8 direct KPI input on current main - #188

Closed
seonghobae wants to merge 3 commits into
mainfrom
fix/compute-kpi-fatal-utf8-current-main-v2
Closed

fix(kpi): restack fatal UTF-8 direct KPI input on current main#188
seonghobae wants to merge 3 commits into
mainfrom
fix/compute-kpi-fatal-utf8-current-main-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Fresh protected-main successor to #123 on exact current base 7273310ae17927d16d0b65d432adbfdb4b193d5b. No predecessor checks, reviews, scanner output, model judgment, production KPI, or release evidence transfers.

Test-first current-main head is 2b3bdb11aa3b616ac8ed5d8995720fd89b6be794: only the deterministic direct-KPI input-integrity regression is present while protected scripts/compute-kpi.mjs still uses non-fatal readFileSync(path, "utf8"). The regression injects malformed retained UTF-8 into an otherwise valid /exchange record and requires failure before metric output while separately pinning valid metrics and the existing non-JSON-line policy.

The narrow GREEN remedy will read exact bytes and decode with TextDecoder("utf-8", { fatal: true }) before line/JSON/metric semantics. Exact current-head application CI, reviewer-ci, protected-base eligible central Security Scan, reviews/threads and live-base identity must be reacquired; queued/absent/skipped/predecessor evidence remains non-passing.

Supersedes #123 only after this current-main successor proves and integrates the complete contract.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f07e1b95-6f39-45c5-8abd-4a6e0b39920b

📥 Commits

Reviewing files that changed from the base of the PR and between 59de169 and a72597e.

📒 Files selected for processing (2)
  • scripts/compute-kpi.mjs
  • test/compute-kpi-input-integrity.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant