Skip to content

fix(kpi): reject malformed UTF-8 on current protected main - #192

Merged
seonghobae merged 2 commits into
mainfrom
fix/compute-kpi-fatal-utf8-current-main-v4
Aug 11, 2026
Merged

fix(kpi): reject malformed UTF-8 on current protected main#192
seonghobae merged 2 commits into
mainfrom
fix/compute-kpi-fatal-utf8-current-main-v4

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Fresh protected-main successor to #190/#188/#123 on exact base 1521180d3b3bb519c7bef59f74b9d723ab93fa3a. No predecessor checks, reviews, scanner output, model judgment, production KPI, or release evidence transfers.

Test-first RED candidate head 98fcf82f648ef8349a806800fb15b44abc62977d contains only the deterministic direct-KPI input-integrity regression while protected scripts/compute-kpi.mjs still reads NDJSON with non-fatal UTF-8 decoding. The regression injects byte 0xff into an otherwise valid /exchange record and requires the command to fail before metric output, while separately preserving valid UTF-8 metrics and the established non-JSON-line policy.

The narrow GREEN remedy is to decode exact bytes with fatal UTF-8 before line/JSON/metric semantics. Exact RED proof will be collected before the production change; then exact-head application CI, reviewer-ci, protected-base eligible central Security Scan, reviews/threads, and live-base identity will be reacquired. Pending/absent/skipped/predecessor evidence remains non-passing.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e364a62-4f98-4a41-beb5-908b3e3f3653

📥 Commits

Reviewing files that changed from the base of the PR and between 1521180 and e5ce27b.

📒 Files selected for processing (2)
  • scripts/compute-kpi.mjs
  • test/compute-kpi-input-integrity.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 23:14
@seonghobae
seonghobae merged commit cd40474 into main Aug 11, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/compute-kpi-fatal-utf8-current-main-v4 branch August 11, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant