fix(kpi): restack fatal UTF-8 direct KPI input on latest main - #190
Closed
seonghobae wants to merge 2 commits into
Closed
fix(kpi): restack fatal UTF-8 direct KPI input on latest main#190seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh protected-main successor to #188/#123 on exact base
0c4e8929d3ecad80fd930b5ddde0e3b8db3016ff. No predecessor checks, reviews, scanner output, model judgment, production KPI, or release evidence transfers.Test-first head
ff474843ba8733a58c95296eb98d17b7f070dae5contains only the deterministic direct-KPI input-integrity regression while protectedscripts/compute-kpi.mjsstill uses non-fatal UTF-8 decoding. The regression injects malformed retained UTF-8 into an otherwise valid/exchangerecord and requires failure before metric output while separately pinning valid metrics and the existing non-JSON-line policy.The narrow GREEN remedy reads exact bytes and decodes with fatal UTF-8 before line/JSON/metric semantics. Exact-head application CI, reviewer-ci, protected-base eligible central Security Scan, reviews/threads, and live-base identity must be reacquired. Pending/absent/skipped/predecessor evidence remains non-passing.
Supersedes #188/#123 only after this successor proves and integrates the complete contract.