chore: [IOCOM-3152] removal of FP-ts from allPaginated - collection.lastRequest#8129
Open
forrest57 wants to merge 6 commits into
Open
chore: [IOCOM-3152] removal of FP-ts from allPaginated - collection.lastRequest#8129forrest57 wants to merge 6 commits into
forrest57 wants to merge 6 commits into
Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8129 +/- ##
===========================================
+ Coverage 62.22% 81.56% +19.33%
===========================================
Files 1940 8 -1932
Lines 36637 282 -36355
Branches 6053 60 -5993
===========================================
- Hits 22798 230 -22568
+ Misses 12488 40 -12448
+ Partials 1351 12 -1339
... and 1937 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
this PR migrates
collection.lastRequestfromO.Option<data>todata|undefinedList of changes proposed in this pull request
How to test
automated tests should pass