Skip to content

chore: [IOCOM-3152] removal of FP-ts from allPaginated - collection.lastRequest#8129

Open
forrest57 wants to merge 6 commits into
masterfrom
IOCOM-3152-fe-allpaginated-rimozione-fp-ts-da-collection
Open

chore: [IOCOM-3152] removal of FP-ts from allPaginated - collection.lastRequest#8129
forrest57 wants to merge 6 commits into
masterfrom
IOCOM-3152-fe-allpaginated-rimozione-fp-ts-da-collection

Conversation

@forrest57
Copy link
Copy Markdown
Contributor

Short description

⚠️ depends on #8127

this PR migrates collection.lastRequest from O.Option<data> to data|undefined

List of changes proposed in this pull request

  • updated types
  • updated reducer to match
  • updated impacted tests and components

How to test

automated tests should pass

@forrest57 forrest57 self-assigned this May 22, 2026
@forrest57 forrest57 added the IO-FIP IO Foundation - Interazioni & Preferenze label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 79.48718% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.56%. Comparing base (0c724d3) to head (4b7832b).

Files with missing lines Patch % Lines
...ures/messages/store/reducers/allPaginated/index.ts 76.23% 24 Missing ⚠️
...cers/allPaginated/upsertMessageStatusAttributes.ts 79.06% 3 Missing and 6 partials ⚠️
...ssages/store/reducers/allPaginated/loadNextPage.ts 87.50% 1 Missing and 1 partial ⚠️
...es/store/reducers/allPaginated/loadPreviousPage.ts 88.23% 1 Missing and 1 partial ⚠️
.../messages/store/reducers/allPaginated/reloadAll.ts 83.33% 1 Missing and 1 partial ⚠️
.../reducers/allPaginated/automaticMessagesRefresh.ts 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8129       +/-   ##
===========================================
+ Coverage   62.22%   81.56%   +19.33%     
===========================================
  Files        1940        8     -1932     
  Lines       36637      282    -36355     
  Branches     6053       60     -5993     
===========================================
- Hits        22798      230    -22568     
+ Misses      12488       40    -12448     
+ Partials     1351       12     -1339     
Files with missing lines Coverage Δ
ts/features/messages/components/Home/homeUtils.ts 86.04% <ø> (-0.17%) ⬇️
ts/features/messages/store/reducers/index.ts 100.00% <ø> (ø)
.../reducers/allPaginated/automaticMessagesRefresh.ts 83.33% <83.33%> (ø)
...ssages/store/reducers/allPaginated/loadNextPage.ts 87.50% <87.50%> (ø)
...es/store/reducers/allPaginated/loadPreviousPage.ts 88.23% <88.23%> (ø)
.../messages/store/reducers/allPaginated/reloadAll.ts 83.33% <83.33%> (ø)
...cers/allPaginated/upsertMessageStatusAttributes.ts 79.06% <79.06%> (ø)
...ures/messages/store/reducers/allPaginated/index.ts 76.23% <76.23%> (ø)

... and 1937 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c724d3...4b7832b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-FIP IO Foundation - Interazioni & Preferenze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant