Skip to content

chore: [IOCOM-3153] removal of FP-TS from allPaginated selectors#8131

Merged
forrest57 merged 18 commits into
masterfrom
IOCOM-3153-fe-allpaginated-rimozione-fp-ts-da-selector
Jun 10, 2026
Merged

chore: [IOCOM-3153] removal of FP-TS from allPaginated selectors#8131
forrest57 merged 18 commits into
masterfrom
IOCOM-3153-fe-allpaginated-rimozione-fp-ts-da-selector

Conversation

@forrest57

Copy link
Copy Markdown
Contributor

Short description

this PR removes FP-TS from said area's selectors
⚠️ depends on #8129

List of changes proposed in this pull request

  • updated selectors to not use FP-TS abstractions
  • removed now unnecessary utilities
  • refactored various selectors to not use currying
  • updated tests to match

How to test

automated tests should pass.

@forrest57 forrest57 self-assigned this May 22, 2026
@forrest57 forrest57 added the IO-FIP IO Foundation - Interazioni & Preferenze label May 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.34%. Comparing base (60b5808) to head (7b1dee2).

Files with missing lines Patch % Lines
...ures/messages/store/reducers/allPaginated/index.ts 76.92% 14 Missing and 1 partial ⚠️
...es/messages/components/Home/PagerViewContainer.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8131      +/-   ##
==========================================
- Coverage   62.35%   62.34%   -0.01%     
==========================================
  Files        1952     1950       -2     
  Lines       36820    36801      -19     
  Branches     6130     6142      +12     
==========================================
- Hits        22959    22945      -14     
+ Misses      12506    12499       -7     
- Partials     1355     1357       +2     
Files with missing lines Coverage Δ
.../ts/features/messages/components/Home/homeUtils.ts 82.02% <100.00%> (-4.03%) ⬇️
...es/messages/components/Home/PagerViewContainer.tsx 78.94% <20.00%> (ø)
...ures/messages/store/reducers/allPaginated/index.ts 84.04% <76.92%> (+7.80%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b5808...7b1dee2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisMattew ChrisMattew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@forrest57 forrest57 added this pull request to the merge queue Jun 10, 2026
Merged via the queue into master with commit f5007a2 Jun 10, 2026
12 checks passed
@forrest57 forrest57 deleted the IOCOM-3153-fe-allpaginated-rimozione-fp-ts-da-selector branch June 10, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-FIP IO Foundation - Interazioni & Preferenze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants