Skip to content

chore: [IOCOM-3146]All paginated reducer split#8127

Merged
forrest57 merged 7 commits into
masterfrom
all-paginated-split
Jun 9, 2026
Merged

chore: [IOCOM-3146]All paginated reducer split#8127
forrest57 merged 7 commits into
masterfrom
all-paginated-split

Conversation

@forrest57

Copy link
Copy Markdown
Contributor

Short description

this PR splits the monolithic allPaginated reducer into small, easier to maintain reducers in order to carry out a systemic refactor of the area

List of changes proposed in this pull request

  • split monolith into separate files for reducers and types
  • updated tests

How to test

automated tests should pass

@forrest57 forrest57 self-assigned this May 22, 2026
@forrest57 forrest57 added the IO-FIP IO Foundation - Interazioni & Preferenze label May 22, 2026
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.83598% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.35%. Comparing base (b6a6740) to head (0e3edbe).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ures/messages/store/reducers/allPaginated/index.ts 74.73% 24 Missing ⚠️
...cers/allPaginated/upsertMessageStatusAttributes.ts 79.06% 3 Missing and 6 partials ⚠️
...ssages/store/reducers/allPaginated/loadNextPage.ts 87.50% 1 Missing and 1 partial ⚠️
...es/store/reducers/allPaginated/loadPreviousPage.ts 88.23% 1 Missing and 1 partial ⚠️
.../messages/store/reducers/allPaginated/reloadAll.ts 83.33% 1 Missing and 1 partial ⚠️
.../reducers/allPaginated/automaticMessagesRefresh.ts 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8127      +/-   ##
==========================================
- Coverage   62.35%   62.35%   -0.01%     
==========================================
  Files        1947     1952       +5     
  Lines       36814    36810       -4     
  Branches     6128     6124       -4     
==========================================
- Hits        22956    22952       -4     
+ Misses      12504    12503       -1     
- Partials     1354     1355       +1     
Files with missing lines Coverage Δ
...n-app/ts/features/messages/store/reducers/index.ts 100.00% <ø> (ø)
.../reducers/allPaginated/automaticMessagesRefresh.ts 83.33% <83.33%> (ø)
...ssages/store/reducers/allPaginated/loadNextPage.ts 87.50% <87.50%> (ø)
...es/store/reducers/allPaginated/loadPreviousPage.ts 88.23% <88.23%> (ø)
.../messages/store/reducers/allPaginated/reloadAll.ts 83.33% <83.33%> (ø)
...cers/allPaginated/upsertMessageStatusAttributes.ts 79.06% <79.06%> (ø)
...ures/messages/store/reducers/allPaginated/index.ts 74.73% <74.73%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bd07c...0e3edbe. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisMattew ChrisMattew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@forrest57 forrest57 added this pull request to the merge queue Jun 9, 2026
Merged via the queue into master with commit f8f8a4a Jun 9, 2026
12 checks passed
@forrest57 forrest57 deleted the all-paginated-split branch June 9, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-FIP IO Foundation - Interazioni & Preferenze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants