Add minimal CI for openshift/bgp-cloud-connector - #82735
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting WalkthroughThis change adds repository-specific Prow plugin settings and a Tide merge query for ChangesRepository Prow integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`:
- Around line 5-7: Remove the repo-level lgtm configuration block from
_pluginconfig.yaml, including the repos entry for openshift/bgp-cloud-connector;
rely on the organization-level inherited lgtm plugin and leave other plugin
configuration unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9d832653-9437-42ae-a46f-c05ae48cb1c4
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yamlcore-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yamlcore-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml
| lgtm: | ||
| - repos: | ||
| - openshift/bgp-cloud-connector |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Remove the repo-level lgtm block.
This repo inherits the lgtm plugin at the org level. Do not add lgtm again at the repo level. This duplication can cause make prow-config or determinize-prow-config to fail with a duplicate plugin error.
🔧 Proposed fix
approve:
- repos:
- openshift/bgp-cloud-connector
require_self_approval: false
-lgtm:
-- repos:
- - openshift/bgp-cloud-connector
plugins:
openshift/bgp-cloud-connector:
plugins:
- approveBased on learnings, repo-level _pluginconfig.yaml files should generally not add the lgtm plugin since it is inherited at the org level, and doing so "can cause make prow-config / determinize-prow-config to fail with a duplicate plugin error."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| lgtm: | |
| - repos: | |
| - openshift/bgp-cloud-connector |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`
around lines 5 - 7, Remove the repo-level lgtm configuration block from
_pluginconfig.yaml, including the repos entry for openshift/bgp-cloud-connector;
rely on the organization-level inherited lgtm plugin and leave other plugin
configuration unchanged.
Source: Learnings
c825865 to
baac17d
Compare
Enable approve, lgtm, and label plugins. Tide merge policy requires `approved` and `lgtm` labels on `main`. CI will be handled via Konflux. Co-Authored-By: Claude
baac17d to
73cdf9c
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Summary
openshift/bgp-cloud-connectorwith minimal CI: image build fromDockerfileand unit tests viamake testfrom_repositorybuild root (.ci-operator.yamlfrom the repo targeting Go 1.26, OCP 4.23 integration stream)approvedlabel onmainto allow self-merging during initial bootstrap🤖 Generated with Claude Code
Summary by CodeRabbit
openshift/bgp-cloud-connector.Dockerfileand runs unit tests withmake test..ci-operator.yamlbuild root with Go 1.26 and the OCP 4.23 integration stream.approve,lgtm, andlabel.mainwhen they have theapprovedandlgtmlabels and no blocking labels.