Skip to content

Add Prow plugin and tide config for openshift/bgp-cloud-connector - #82795

Open
alebedev87 wants to merge 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector
Open

Add Prow plugin and tide config for openshift/bgp-cloud-connector#82795
alebedev87 wants to merge 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector

Conversation

@alebedev87

@alebedev87 alebedev87 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable approve, lgtm, and label plugins for openshift/bgp-cloud-connector
  • Tide merge policy requires approved and lgtm labels on main
  • CI will be handled via Konflux

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Added Prow configuration for openshift/bgp-cloud-connector.
  • Enabled the approve, lgtm, and label plugins without requiring self-approval.
  • Configured Tide to merge pull requests into main only when they have both approved and lgtm labels.
  • Excluded pull requests with hold, ownership, Jira, or rebase-related labels.
  • Delegated CI handling to Konflux.

@openshift-ci
openshift-ci Bot requested review from hector-vido and pruan-rht August 3, 2026 09:48
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e331694f-bc55-4e64-9dea-5c1f5b8c3e4a

📥 Commits

Reviewing files that changed from the base of the PR and between 73cdf9c and 5666e0c.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

Walkthrough

Adds Prow plugin and Tide configuration for openshift/bgp-cloud-connector. The configuration enables approval and LGTM handling, disables self-approval requirements, and defines merge criteria for the main branch.

Changes

Prow repository onboarding

Layer / File(s) Summary
Approval plugins and Tide merge criteria
core-services/prow/02_config/openshift/bgp-cloud-connector/*
Enables the approve plugin, configures approval and LGTM handling, disables self-approval requirements, and requires approved and lgtm labels for main while rejecting blocking labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: lgtm

Suggested reviewers: hector-vido, pruan-rht

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the added Prow plugin and Tide configuration for openshift/bgp-cloud-connector.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch adds only two YAML Prow configuration files and contains no Ginkgo declarations or test titles to assess.
Test Structure And Quality ✅ Passed The pull request changes only two Prow YAML files. It adds no Ginkgo tests or cluster operations, so the listed test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The PR adds only two Prow YAML configuration files. It adds no Ginkgo tests or test references that require MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit adds only two Prow YAML configuration files and no Ginkgo e2e tests, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The change adds only Prow plugin and Tide YAML; it adds no deployment, operator, controller, replica, affinity, topology, node, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML Prow configuration files; the affected directory has no Go source or process-level OTE code, so no stdout contract violation applies.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only two Prow YAML files. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The changed files contain only Prow approval, LGTM, plugin, and Tide YAML. No weak-crypto algorithm, custom crypto, or secret comparison is present.
Container-Privileges ✅ Passed The commit adds only Prow plugin and Tide configuration. Added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The two added YAML files contain only Prow plugin and Tide label configuration; searches found no logging constructs or sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`:
- Around line 5-7: Add review-based LGTM configuration for the
openshift/bgp-cloud-connector repository by setting review_acts_as_lgtm to true
in the plugin configuration alongside the existing lgtm repository entry, so
GitHub approvals satisfy the Tide query.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 498608e6-2853-487e-bf6f-743149767fcf

📥 Commits

Reviewing files that changed from the base of the PR and between a996379 and 73cdf9c.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

Enable approve, lgtm, and label plugins. Tide merge policy requires
`approved` and `lgtm` labels on `main`. CI will be handled via Konflux.

Co-Authored-By: Claude
@alebedev87
alebedev87 force-pushed the bgp-cloud-connector branch from 73cdf9c to 5666e0c Compare August 3, 2026 10:10
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@alebedev87: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant