Update golangci-lint to v2.10.1 for openshift/installer CI configs#76039
Conversation
|
/pj-rehearse |
|
@hasbro17: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc @patrickdillon |
hasbro17
force-pushed
the
update-golanglint-ci-for-installer
branch
from
f2bc833 to
2062c14
Compare
hasbro17
changed the title
|
Changed to v2.10.1 as that's the actual version available to us in https://quay.io/repository/openshiftci/golangci-lint?tab=tags&tag=latest |
|
There's another PR open for this at #75091 Let's see if this version fares any better with the rehearsals /pj-rehearse pull-ci-openshift-installer-main-golint |
|
@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The linter is failing on some existing code, perhaps so that you don't get stuck trying to fix all the lint issues, you can update the --new-from-rev flag later in this file to a point to a recent installer commit, such as |
Bump the golangci-lint base image tag from v2.3.1 to v2.10.1 in the main, release-4.22, release-4.23, and release-5.0 CI configurations for openshift/installer to add support for Go 1.25 Also update --new-from-rev to a6ba91c to ignore prior linting errors
hasbro17
force-pushed
the
update-golanglint-ci-for-installer
branch
from
2062c14 to
6955b35
Compare
|
Updated |
|
/pj-rehearse pull-ci-openshift-installer-main-golint |
|
@hasbro17: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 493 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasbro17, tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
|
@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@hasbro17: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…penshift#76039) Bump the golangci-lint base image tag from v2.3.1 to v2.10.1 in the main, release-4.22, release-4.23, and release-5.0 CI configurations for openshift/installer to add support for Go 1.25 Also update --new-from-rev to a6ba91c to ignore prior linting errors
…penshift#76039) Bump the golangci-lint base image tag from v2.3.1 to v2.10.1 in the main, release-4.22, release-4.23, and release-5.0 CI configurations for openshift/installer to add support for Go 1.25 Also update --new-from-rev to a6ba91c to ignore prior linting errors
…penshift#76039) Bump the golangci-lint base image tag from v2.3.1 to v2.10.1 in the main, release-4.22, release-4.23, and release-5.0 CI configurations for openshift/installer to add support for Go 1.25 Also update --new-from-rev to a6ba91c to ignore prior linting errors
4 participants
Bump the golangci-lint base image tag from v2.3.1 to v2.10.1 in the main, release-4.22, release-4.23, and release-5.0 CI configurations for openshift/installer to add support for Go 1.25
Required as ci/prow/golint fails on openshift/installer#10376 with the Go 1.25 bump.