Skip to content

no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support#10397

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pawanpinjarkar:patch-7
Mar 17, 2026
Merged

no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support#10397
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pawanpinjarkar:patch-7

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Mar 16, 2026

Updates the golangci-lint Docker image from v2.3.1 to v2.10.1 to fix the linter breaking after the Go 1.25 upgrade.
The previous version (v2.3.1) was built with Go 1.24.5 and failed with the error:
"the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)".

Also, updated --new-from-rev flag

The changes are in sync with ci: openshift/release#76039

Run: ./hack/go-lint.sh

This only affects developers running hack/go-lint.sh locally. CI uses the rhel-9-release-golang-1.25-openshift-4.22 build image which already has the correct linter version.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1ac0eca-2214-46a0-94b2-0b449435bb4a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updated the golangci-lint container image version in hack/go-lint.sh from v2.3.1 to v2.4.0 with no changes to command or workflow.

Changes

Cohort / File(s) Summary
Container Image Version Update
hack/go-lint.sh
Updated golangci-lint container image from v2.3.1 to v2.4.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@pawanpinjarkar
Copy link
Contributor Author

/cc @patrickdillon @sadasu

@patrickdillon
Copy link
Contributor

Can you bump to v2.10.1 the same version used in ci: openshift/release#76039

@tthvo
Copy link
Member

tthvo commented Mar 17, 2026

Can you bump to v2.10.1 the same version used in ci: openshift/release#76039

+1. We may also need to update --new-from-rev flag to a more recent commit (e.g. latest main). See openshift/release#76039 (comment)

Updates the golangci-lint Docker image from v2.3.1 to v2.10.1 to fix the linter breaking after the Go 1.25 upgrade.
The previous version (v2.3.1) was built with Go 1.24.5 and failed with the error:
"the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)".

Also, updated --new-from-rev flag

The changes are in sync with ci: openshift/release#76039
@pawanpinjarkar pawanpinjarkar changed the title Bump golangci-lint to v2.4.0 for Go 1.25 support Bump golangci-lint to v2.10.1 for Go 1.25 support Mar 17, 2026
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@tthvo
Copy link
Member

tthvo commented Mar 17, 2026

/retitle no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support

@openshift-ci openshift-ci bot changed the title Bump golangci-lint to v2.10.1 for Go 1.25 support no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support Mar 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request explicitly references no jira issue.

Details

In response to this:

Updates the golangci-lint Docker image from v2.3.1 to v2.10.1 to fix the linter breaking after the Go 1.25 upgrade.
The previous version (v2.3.1) was built with Go 1.24.5 and failed with the error:
"the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)".

Also, updated --new-from-rev flag

The changes are in sync with ci: openshift/release#76039

Run: ./hack/go-lint.sh

This only affects developers running hack/go-lint.sh locally. CI uses the rhel-9-release-golang-1.25-openshift-4.22 build image which already has the correct linter version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member

tthvo commented Mar 17, 2026

/verified by ./hack/go-lint.sh

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@openshift-ci-robot
Copy link
Contributor

@tthvo: This PR has been marked as verified by ./hack/go-lint.sh.

Details

In response to this:

/verified by ./hack/go-lint.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1896803 into openshift:main Mar 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants