no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support#10397
no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support#10397openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated the golangci-lint container image version in hack/go-lint.sh from v2.3.1 to v2.4.0 with no changes to command or workflow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
Can you bump to v2.10.1 the same version used in ci: openshift/release#76039 |
+1. We may also need to update |
Updates the golangci-lint Docker image from v2.3.1 to v2.10.1 to fix the linter breaking after the Go 1.25 upgrade. The previous version (v2.3.1) was built with Go 1.24.5 and failed with the error: "the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)". Also, updated --new-from-rev flag The changes are in sync with ci: openshift/release#76039
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle no-jira: bump golangci-lint to v2.10.1 for Go 1.25 support |
|
@pawanpinjarkar: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by |
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Updates the golangci-lint Docker image from
v2.3.1tov2.10.1to fix the linter breaking after the Go 1.25 upgrade.The previous version (v2.3.1) was built with Go 1.24.5 and failed with the error:
"the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)".
Also, updated
--new-from-revflagThe changes are in sync with ci: openshift/release#76039
Run:
./hack/go-lint.shThis only affects developers running hack/go-lint.sh locally. CI uses the rhel-9-release-golang-1.25-openshift-4.22 build image which already has the correct linter version.