Add repair-only PR intake#290
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 8:03 AM ET / 12:03 UTC. Summary Reproducibility: not applicable. this is a feature PR, not a bug report. Source inspection plus the PR body's terminal proof cover the main changed behavior: cancelled-only scans produce zero candidates and generated jobs use Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this only after a repair-lane maintainer accepts the new durable Do we have a high-confidence way to reproduce the issue? Not applicable; this is a feature PR, not a bug report. Source inspection plus the PR body's terminal proof cover the main changed behavior: cancelled-only scans produce zero candidates and generated jobs use Is this the best way to solve the issue? Yes, with maintainer acceptance of the automation policy. The current branch reuses existing repair job frontmatter, validation, worker-lane routing, and state preservation patterns rather than adding a separate repair system. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7779e2fe93bf. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Updated after ClawSweeper review: preserved repair-pr jobs during jobs publishes, stopped treating transient UNKNOWN merge state as actionable, added regression coverage, and added real dry-run proof in the PR body. This would have prevented exactly the first failed submission of this PR from sitting unhandled: the intake now detects the ClawSweeper failure/comment and plans a durable repair-pr job. @clawsweeper re-review |
|
Updated after second ClawSweeper review: CANCELLED checks no longer create repair jobs, repair-pr jobs now render job_intent:pr_repair and classify as PR repair work, and focused regressions were added for cancelled-check gating, job intent, and work kind. Added refreshed real proof in the PR body: cancelled-only dry-run now produces 0 candidates, and a safe /tmp generation produces job_intent:pr_repair. @clawsweeper re-review |
|
Maintainer follow-up completed:
|
Summary
Pre-publication checks
Real behavior proof
Cancelled-check gating proof:
Excerpt:
This confirms the intake no longer creates durable repair jobs from CANCELLED-only checks.
PR-repair job shape proof, written to /tmp only so no real queue state was mutated:
Excerpt:
This shows generated PR-intake jobs are durable preserved jobs with a deliberate pr_repair intent and PR-repair work classification, not cluster repair.
Verification