Separate human-only PR intake signals#307
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 16, 2026, 3:01 AM ET / 07:01 UTC. Summary Reproducibility: yes. for the review finding: the GitHub Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the intake split only after the file is formatted, focused coverage validates the new classifications, and the PR body includes redacted dry-run output from representative real PR states. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: the GitHub Is this the best way to solve the issue? No, not yet: the implementation direction is plausible, but the current branch is not the best mergeable solution until formatting is fixed and real intake-output proof establishes the classification boundary. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c88270b81889. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Closing rather than repairing this branch. It combines signal classification with watch-silence state, has no regression coverage for either path, and is superseded operationally by narrower intake work. The useful classification idea can return as a focused, tested change. Thank you for the proposal. |
|
Closing this branch for now instead of trying to prove it with local operational runs. If the human-only intake separation is still needed, it should come back as a small, model-agnostic PR with clean checks and upstream-clean tests/proof. Any adapter or non-Codex-specific behavior must not be part of ClawSweeper. |
Summary
requires_humanresults for PRs that only have human/workflow metadata and no repairable blockerproof: sufficientis already presentRationale
Repair-only intake should enqueue jobs only when there is an objective repairable blocker, such as failed checks, dirty/blocked merge state, changes requested, or unresolved actionable review threads. Stale labels and human workflow status should be reported separately for maintainer attention instead of creating repair work.
Verification
corepack pnpm install --frozen-lockfilecorepack pnpm run build:repairnode --test test/repair/pr-repair-intake.test.ts