feat(web): make the rails flush boxes and move the canvas gradient - #4020
Conversation
|
❌ UI Snapshot doesn't match the committed baseline. If this UI change is intentional, update the baseline — each path renders in the same pinned image, so the result matches this gate:
Diff PNGs ( |
|
c5d88a2 to
3c8feef
Compare
|
UI Preview for this PR has been removed. |
4ab1957 to
2f6f0d5
Compare
The sidebar and workspace rails were floating cards (margin, rounded corners, border, shadow) on a gradient canvas. The design has them flush to the window edges, reading as part of the canvas. - Left sidebar and right workspace rail sit flush: no outer margin, no rounding, no drop shadow. The workspace rail keeps a left divider. - Light canvas is flat white; the brand gradient moves onto the left sidebar, joined by the mock's dot-grid and pink corner glow. - Dark canvas carries the mock's purple gradient; the dark sidebar gets the same dot-grid plus a purple bottom wash and the diagonal sheen. - Both rails are excluded from the dark glass rule instead of overriding it, so they no longer pick up its blur, sheen, fill, or border. The workspace rail's panel contents are transparent too. - Dark surface tokens (--card, --card-solid, --tray, --muted, --background) move off their purple tint onto neutral slate. Consolidates the canvas/rail CSS so each surface owns its full background in one rule, and drops the now-redundant ::before dot overlay. Co-authored-by: Isaac Signed-off-by: Hubert Zub <hubert.zub@databricks.com>
2f6f0d5 to
bdbcd90
Compare
|
✅ Regenerated the visual baseline(s) in the pinned Playwright image and pushed to this PR. CI will re-run on the new commit. |
|
🏷️ Doc impact: Purely cosmetic CSS/theme retuning of dark-mode colors and sidebar/workspace panel styling with matching test/snapshot updates — no user-facing behavior, integration, or documented default changed. Auto-classified on merge. Set the label manually before merging to override. · run |
Related issue
Closes OMNI-2357, closes OMNI-2349
Summary
The sidebar and workspace rails were floating cards (outer margin, rounded corners, border, drop shadow) on a gradient canvas. The design has them flush to the window edges, reading as part of the canvas — so the card treatment comes off and the gradient moves onto the sidebar.
--card,--card-solid,--tray,--muted,--background).Also consolidates the canvas/rail CSS: each surface owns its full
backgroundin one rule, and the redundant::beforedot overlay is gone.Stacked on #4019 (Zinc tokens) — review that one first.
Test Plan
npm run testfor the touched suites —index.css.test.ts(glass-rule minification + selector DOM guards),Sidebar,AppShell,WorkspacePanel,Sidebar.subagentHighlight: 201 passing. Layout assertions updated to the flush design.npm run type-check,oxlint,prettier --checkclean.Demo
Type of change
Test coverage
Coverage notes
The change is visual, so the unit tests cover the structural contracts that can regress silently — the dark glass-rule minification and selector guards in
index.css.test.ts, plus the sidebar and workspace-panel layout classes. Colours and gradients were verified manually in both themes against the prototype (flat canvas, flush rails, sidebar dot-grid and glow, neutral dark surfaces, de-glassed rails).Changelog
The sidebar and side panel now sit flush against the window edges, with the background gradient moved onto the sidebar.