feat(web): set the text size steps from the design - #4021
Conversation
|
|
❌ UI Snapshot doesn't match the committed baseline. If this UI change is intentional, update the baseline — each path renders in the same pinned image, so the result matches this gate:
Diff PNGs ( |
5aa846c to
1ea04bc
Compare
dca8dfd to
2f210a8
Compare
Body and chat-thread text are both 13px/18px in the design; the shared `text-13` step was on a 20px line, so tighten it to 18px. Adds the 12px/16px caption step used by sidebar section subtitles (Projects, Sessions). Defines the steps only — switching each surface onto them is follow-up work. Co-authored-by: Isaac Signed-off-by: Hubert Zub <hubert.zub@databricks.com>
2f210a8 to
7994e1d
Compare
|
UI Preview for this PR has been removed. |
The chat thread hard-coded its own 15px/24px with negative tracking, and sidebar rows set a size but no line height, so neither matched the design. - Chat bubbles (user and assistant share the wrapper): 13px/18px, and the -0.01em tracking is dropped — the design specifies 0. - Sidebar body rows: pin the line height to 18/13 of the font size, which was previously left to inherit. Both stay in rem/unitless so the mobile root-font bump and the Appearance font-size setting keep scaling them. Sidebar section captions were already 12px/16px and are unchanged. Co-authored-by: Isaac
|
✅ Regenerated the visual baseline(s) in the pinned Playwright image and pushed to this PR. CI will re-run on the new commit. |
1.3846 was the 18/13 ratio written as a unitless number — unreadable, and it took arithmetic to confirm it meant 18px. 1.125rem is 18px directly and scales the same way, matching how the chat wrapper states it. Co-authored-by: Isaac
|
🏷️ Doc impact: Pure CSS/typography tweaks (font size and line-height for chat/sidebar text) plus updated visual snapshot baselines; no user-facing surface, integration, or documented behavior changed. Auto-classified on merge. Set the label manually before merging to override. · run |
* feat(web): set the text size steps from the design Body and chat-thread text are both 13px/18px in the design; the shared `text-13` step was on a 20px line, so tighten it to 18px. Adds the 12px/16px caption step used by sidebar section subtitles (Projects, Sessions). Defines the steps only — switching each surface onto them is follow-up work. Co-authored-by: Isaac Signed-off-by: Hubert Zub <hubert.zub@databricks.com> * feat(web): put chat and sidebar text on the design's type scale The chat thread hard-coded its own 15px/24px with negative tracking, and sidebar rows set a size but no line height, so neither matched the design. - Chat bubbles (user and assistant share the wrapper): 13px/18px, and the -0.01em tracking is dropped — the design specifies 0. - Sidebar body rows: pin the line height to 18/13 of the font size, which was previously left to inherit. Both stay in rem/unitless so the mobile root-font bump and the Appearance font-size setting keep scaling them. Sidebar section captions were already 12px/16px and are unchanged. Co-authored-by: Isaac * test(e2e-ui): regenerate visual baselines * refactor(web): express the sidebar line height in rem 1.3846 was the 18/13 ratio written as a unitless number — unreadable, and it took arithmetic to confirm it meant 18px. 1.125rem is 18px directly and scales the same way, matching how the chat wrapper states it. Co-authored-by: Isaac --------- Signed-off-by: Hubert Zub <hubert.zub@databricks.com> Co-authored-by: Hubert Zub <hubert.zub@databricks.com> Co-authored-by: omnigent-ci[bot] <294685417+omnigent-ci[bot]@users.noreply.github.com> Co-authored-by: Hubert <hubert.zub@gmail.com>
* feat(web): set the text size steps from the design Body and chat-thread text are both 13px/18px in the design; the shared `text-13` step was on a 20px line, so tighten it to 18px. Adds the 12px/16px caption step used by sidebar section subtitles (Projects, Sessions). Defines the steps only — switching each surface onto them is follow-up work. Co-authored-by: Isaac Signed-off-by: Hubert Zub <hubert.zub@databricks.com> * feat(web): put chat and sidebar text on the design's type scale The chat thread hard-coded its own 15px/24px with negative tracking, and sidebar rows set a size but no line height, so neither matched the design. - Chat bubbles (user and assistant share the wrapper): 13px/18px, and the -0.01em tracking is dropped — the design specifies 0. - Sidebar body rows: pin the line height to 18/13 of the font size, which was previously left to inherit. Both stay in rem/unitless so the mobile root-font bump and the Appearance font-size setting keep scaling them. Sidebar section captions were already 12px/16px and are unchanged. Co-authored-by: Isaac * test(e2e-ui): regenerate visual baselines * refactor(web): express the sidebar line height in rem 1.3846 was the 18/13 ratio written as a unitless number — unreadable, and it took arithmetic to confirm it meant 18px. 1.125rem is 18px directly and scales the same way, matching how the chat wrapper states it. Co-authored-by: Isaac --------- Signed-off-by: Hubert Zub <hubert.zub@databricks.com> Co-authored-by: Hubert Zub <hubert.zub@databricks.com> Co-authored-by: omnigent-ci[bot] <294685417+omnigent-ci[bot]@users.noreply.github.com> Co-authored-by: Hubert <hubert.zub@gmail.com> Co-authored-by: Nick Isaacs <nick.isaacs@datadoghq.com>
Related issue
Closes OMNI-2331
Summary
Sets the text size steps from the design:
text-13step — its line height was 20px and is now 18px. No separate chat token, since a second 13/18 step would be a duplicate.text-caption).Scope caveat: this defines the steps.
text-13has existing consumers so the 18px line lands immediately, but pointing the chat thread and sidebar subtitles at these steps is follow-up work — that part of OMNI-2331 is not done here.Stacked on #4020 (rails + backgrounds) — review that one first.
Test Plan
npm run testfor the touched suites —index.css.test.ts,Sidebar,AppShell,WorkspacePanel,Sidebar.subagentHighlight: 201 passing.prettier --checkclean.text-13(composer footer selectors, slash-command rows) for the tighter line height.Demo
N/A — type-scale values only.
Type of change
Test coverage
Coverage notes
A line-height value change has no behavioral surface to unit-test; the existing suites confirm nothing regressed, and the tighter line was checked by eye on the surfaces already using
text-13.Changelog
Tightened body and chat text to the design's 13/18 type scale.