[Issue-259] SameSite attribute is not preserved#262
Merged
Conversation
Collaborator
|
Looks good; thanks! I set the version back to 2.1 since it doesn't quite seem major-version worthy. I also added a NoSuchMethod check to hopefully keep Servlet 5.0.0 support... albeit not tested. |
Collaborator
|
LMK if looks good to you. If so I'll merge and release this week. |
Contributor
Author
|
Hi @dsmiley , Looks good to me, but I think the comment in the try-catch-block is misleading, as Servlet 5.0 is already jakarta - it is just missing the method. Conterproposal: "Servlet 6.0+ only; SameSite not preserved on older versions (e.g. Servlet 5.0)" |
dsmiley
approved these changes
Apr 25, 2026
Contributor
Author
|
Looks good to me, @dsmiley . As far as I am concerned this can be merged and the ticket can be closed :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: This PR has been implemented with the help of Claude Code.
These changes fix #259 and bump the servlet API to 6.0.0. Due to the discussion in #260 Jetty has been replaced with Tomcat.