Skip to content

[Issue-259] SameSite attribute is not preserved#260

Closed
nils-christian wants to merge 1 commit into
mitre:masterfrom
nils-christian:issue-259
Closed

[Issue-259] SameSite attribute is not preserved#260
nils-christian wants to merge 1 commit into
mitre:masterfrom
nils-christian:issue-259

Conversation

@nils-christian
Copy link
Copy Markdown
Contributor

Disclaimer: This PR has been implemented with the help of Claude Code.

These changes fix #259 and bump the servlet API to 6.0.0.

Comment thread pom.xml
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-servlet</artifactId>
<version>11.0.15</version>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jakartaee.github.io/platform/jakartaee10/JakartaEE10ReleasePlan shows servlet 6 only requires Java 11. But this PR adds Jetty dependencies that elevate to Java 17.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dsmiley ,

According to https://jetty.org/download.html the lowest jetty version to support servlet 6.0 is jetty 12, which in turn does indeed require Java 17. I don't think that this is a problem, as it is just a test dependency. Another idea would be to use Tomcat 10.1.x, which would support Servlet 6.0 but still Java 11.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #262.

@dsmiley
Copy link
Copy Markdown
Collaborator

dsmiley commented Apr 21, 2026

Lets go with #262 for a 2.1 release of the proxy. In 3.0, I'll move onto JDK 17 & Servlet 6 more firmly, and hopefully merge that JDK HttpClient switch, which is a big deal. As one of my users, I'd appreciate any test/evaluation support you may have to offer for , as I'm currently not really a user of the proxy.

@nils-christian
Copy link
Copy Markdown
Contributor Author

Closed in favor of #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SameSite attribute is not preserved

2 participants