Include more systemd units in the tarball#159
Conversation
mgoltzsche
left a comment
mgoltzsche
left a comment
There was a problem hiding this comment.
Thanks for your contribution @cyqsimon!
I have only one suggestion...
| RUN make contrib/systemd/system/netavark-{dhcp-proxy,firewalld-reload,nftables-reload}.service; \ | ||
| rm -f contrib/systemd/system/*.in |
There was a problem hiding this comment.
Let's make sure that the whole RUN instruction fails when the make call fails:
| RUN make contrib/systemd/system/netavark-{dhcp-proxy,firewalld-reload,nftables-reload}.service; \ | |
| rm -f contrib/systemd/system/*.in | |
| RUN make contrib/systemd/system/netavark-{dhcp-proxy,firewalld-reload,nftables-reload}.service && \ | |
| rm -f contrib/systemd/system/*.in |
There was a problem hiding this comment.
Okay seems like we can't use bash-specific expansion syntax here. I believe Alpine's default /bin/sh is ash?
Anyways, let's block this on containers/netavark#1421 for now. That PR should make this easier.
There was a problem hiding this comment.
This PR was merged a while ago, so we're just waiting on the next netavark minor or major release now.
@mgoltzsche Can you please ping me the next time you bump netavark, if you can remember to do so? Thanks.
There was a problem hiding this comment.
fyi: netavark 2.0.0 has been released but, due to breaking changes, it will work with podman 6 only which is not released yet.
Thus, we'll have to wait a bit longer.
23421cb to
e3910f7
Compare
2 participants
Closes #158.
This PR:
netavark-*units.