Skip to content

Split install into sub-targets#1421

Merged
Luap99 merged 1 commit into
containers:mainfrom
cyqsimon:split-install-targets
Mar 17, 2026
Merged

Split install into sub-targets#1421
Luap99 merged 1 commit into
containers:mainfrom
cyqsimon:split-install-targets

Conversation

@cyqsimon

Copy link
Copy Markdown
Contributor

I was working on mgoltzsche/podman-static#159 when I ran into this problem. There's currently no separate make target for just installing NV_UNIT_FILES, which makes selective packaging a bit annoying.

This PR adds this flexibility without any substantive functional changes.

Comment thread Makefile
@packit-as-a-service

Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

cyqsimon added a commit to cyqsimon/podman-static that referenced this pull request Mar 13, 2026
Comment thread Makefile Outdated
Comment thread Makefile

@lsm5 lsm5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99

Luap99 commented Mar 13, 2026

Copy link
Copy Markdown
Member

Can you squash the commits please?

This allows greater flexibility for packagers.

Signed-off-by: cyqsimon <28627918+cyqsimon@users.noreply.github.com>
@cyqsimon
cyqsimon force-pushed the split-install-targets branch from d7268bb to 3710f63 Compare March 17, 2026 06:46
@cyqsimon

Copy link
Copy Markdown
Contributor Author

Can you squash the commits please?

Done.

@mheon mheon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Luap99 merged commit 058da11 into containers:main Mar 17, 2026
27 checks passed
@cyqsimon
cyqsimon deleted the split-install-targets branch March 18, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants