-
Notifications
You must be signed in to change notification settings - Fork 22
Feat: use new tree listing #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: use new tree listing #1709
Conversation
b0be2f0 to
20d453b
Compare
gustavobtflores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small nit, i'll pre-approve
ee53343 to
a09ec16
Compare
|
and if we have just one route being active at a time, why do we need two different routes? wouldn't be possible to have just /tree and switch behavior with the env flag? |
The idea is that since changing the feature flag is not on our hands, it is useful to still have both versions up so that we can compare them very easily anytime |
- Replaces old treeListing page with new endpoint and status format - Reorganizes the routes and component files - Refactors some component parts in order to be reused between treeListings
Used as a link between the newer and older versions of the treeListing, should be removed after the new tree listing is stable
Adds a feature flag to select the version of the main treeListing page Closes kernelci#1559
a09ec16 to
62d3a4d
Compare
Changes
Logic for the naming of the components/pages/routes:
How to test
Start of with data in the new treeListing table, instructions on how to populate it can be found in #1706
Check the new treeListing page and the old version. Check if the redirects are working as intended
Closes #1559