Skip to content

Conversation

@gustavobtflores
Copy link
Contributor

Description

Promote the new, optimized hardware listing page to be the default view (/hardware) and move the legacy view to an archive route.

@gustavobtflores gustavobtflores marked this pull request as ready for review January 23, 2026 21:56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really a need to do both cases for the same value? IMO you can have just one case for that value and use it in both pages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't get it tbh, why we wouldn't need both cases here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because whenever you would use /hardware/v1 you can just use /hardware since they are exactly the same and don't need semantic differentiation

@gustavobtflores gustavobtflores force-pushed the feat/replace-new-hardware-page branch from 52e5192 to 184dc25 Compare January 26, 2026 18:42
Copy link
Contributor

@AmadeusK525 AmadeusK525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you renamed the old one to v1 you should rename the new one to v2, no?

@gustavobtflores
Copy link
Contributor Author

gustavobtflores commented Jan 26, 2026

I guess if you renamed the old one to v1 you should rename the new one to v2, no?

My concern with /hardware/v2 is that it would require redirecting users from /hardware, which adds avoidable complexity. I'd prefer to keep the new one at /hardware and the old one at /hardware/v1

@MarceloRobert
Copy link
Collaborator

I guess if you renamed the old one to v1 you should rename the new one to v2, no?
@AmadeusK525

It's best if we keep the route as /hardware for backwards compatibility and also because we don't need to increase the url size for no reason. What could be done is what I did for the treeListing on #1709 which is to have three routes: /tree/v1, /tree/v2, and just /tree, meaning routes for specific version and a route for the latest/main version

@MarceloRobert
Copy link
Collaborator

@gustavobtflores there seems to not have much change since the last time I reviewed the PR, you can let me resolve my comments once I see that they have been solved

@gustavobtflores gustavobtflores force-pushed the feat/replace-new-hardware-page branch from 184dc25 to 6e714ca Compare January 27, 2026 17:26
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in the /hardware/v1 route when I change the origin it goes back to the /hardware route. I did change the OriginSelector on my PR, so maybe it's worth checking those changes here

@gustavobtflores gustavobtflores force-pushed the feat/replace-new-hardware-page branch 9 times, most recently from 00dd225 to f442fa0 Compare January 28, 2026 19:26
@gustavobtflores gustavobtflores force-pushed the feat/replace-new-hardware-page branch from f442fa0 to 06cf204 Compare January 28, 2026 19:44
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great

@gustavobtflores gustavobtflores added this pull request to the merge queue Jan 28, 2026
Merged via the queue into kernelci:main with commit 53e3a3d Jan 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants