Add new function: get_bibliography()#602
Open
PietrH wants to merge 65 commits into
Open
Conversation
…ng: doesn't produce warning. Easier to read.
Co-Authored-By: Peter Desmet <peter.desmet@inbo.be>
25 tasks
… changing depending on OS. Co-Authored-By: Peter Desmet <peter.desmet@inbo.be>
1e5510f to
dd5872a
Compare
Co-Authored-By: Peter Desmet <peter.desmet@inbo.be>
…es in front, but don't show duplicates
Merged
Refactor `check_value()`
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 94.80% 95.05% +0.25%
==========================================
Files 33 34 +1
Lines 1559 1639 +80
==========================================
+ Hits 1478 1558 +80
Misses 81 81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_bibliography()that creates a data.frame of references based on a detections-like input data.frame.check_value()to no longer use assertthat, and offer a shorter and more stylish message. When possible, offering suggestions for possible typo's:check_value()calls on the client, I have not made any changes to{etnservice}which retains the same behavior as before this PR. This means that the messages generated by the API will remain very long (include all possible candidate codes) and will offer no suggestions. I can not inherit this function, because all OpenCPU messages are fetched as pure text, and the etn R package uses{cli}.field_definitions.tsvcitation("etn")to be consistent over platforms, and to get it into the shape that I wanted. So we ended up landing on hardcoding it in.field_definitions.tsv, what do you think?qs2serializer for test fixtures (cached HTTP responses) to save space. See: https://qsbase.r-universe.dev/articles/qs2/vignette.html, related to Reduce package size:fixturesare quite big #491