Skip to content

Comments

Fix CI Failures by Pinning .NET Tool Versions#335

Merged
begonaguereca merged 12 commits intomainfrom
begonaguereca-patch-2
Jun 11, 2025
Merged

Fix CI Failures by Pinning .NET Tool Versions#335
begonaguereca merged 12 commits intomainfrom
begonaguereca-patch-2

Conversation

@begonaguereca
Copy link
Collaborator

@begonaguereca begonaguereca commented Jun 10, 2025

What's changing?

✅ Changes

  • Pinned dotnet-format to v5.1.225507 to ensure compatibility with .NET 6.0.
  • Pinned ThirdLicense to v1.2.0, the last version compatible with .NET 6.0.
  • Bumped the version of actions/upload-artifact from v3 to v4
  • Updated artifact upload step to use a dynamically generated name via ${{ github.run_id }} to avoid naming collisions and potential infra-related cache issues.
  • Confirmed workflows run on GitHub-hosted runners, not Azure Pipelines.
  • Added preparation logic to organize dotnet publish output into a unified staging directory before uploading artifacts.

🧪 Validation

  • ✅ Lint passes using the pinned version of dotnet-format.
  • ✅ Tests and license validation succeed using compatible tool versions.

📌 Context

The workflow previously failed due to:

  • CI tools installing incompatible versions targeting .NET 7+
  • Artifact uploads being rejected with Create Artifact Container failed errors, despite valid names

This PR gets CI back into a reliable state and isolates the infra issue for further follow-up.

Closes [related issues]

Copilot AI review requested due to automatic review settings June 10, 2025 16:38
@begonaguereca begonaguereca requested a review from a team as a code owner June 10, 2025 16:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR adds a stray placeholder line to the project's Code of Conduct.

  • Inserts a line containing only "test" into CODE_OF_CONDUCT.md.
Comments suppressed due to low confidence (1)

CODE_OF_CONDUCT.md:4

  • [nitpick] This line appears to be a placeholder and doesn't belong in the Code of Conduct; please remove or replace it with the intended content.
test

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

Unit Test Results

42 tests  ±0   42 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7cea5fa. ± Comparison against base commit f4ebc76.

♻️ This comment has been updated with latest results.

Ferxhysmn

This comment was marked as spam.

@begonaguereca begonaguereca changed the title TEST IGNORE Fix CI Failures by Pinning .NET Tool Versions Jun 11, 2025
Copy link

@offbyone offbyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably wanna delete the test string in the COC markdown file :D

@begonaguereca begonaguereca merged commit 6f6c943 into main Jun 11, 2025
8 checks passed
@begonaguereca begonaguereca deleted the begonaguereca-patch-2 branch June 11, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants