Harden GitHub Actions Workflow Permissions#334
Merged
begonaguereca merged 4 commits intomainfrom Jun 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR tightens workflow security by explicitly setting least-privilege permissions and scoping write access only where needed.
- Adds a top-level
permissions: contents: readto enforce default read-only access. - Grants
contents: writespecifically to thepublishjob.
|
Based on the CI errors, there are dotnet version issues with the existing tools. I seem to recall we may have had a platform upgrade to dotnet recently, based on a PR in gh-gei. Is that related to the CI issues here? |
Collaborator
Author
offbyone
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing?
This PR updates the CI workflow to explicitly define
permissionsin accordance with GitHub security best practices and to resolve theactions/missing-workflow-permissionsCodeQL alert.permissions: contents: readto enforce least-privilege by default.contents: writeto thepublishjob only (required for release creation).checks: writeandpull-requests: writepermissions for theunit-testjob to support publishing test results.How's this tested?
Closes https://github.com/github/gh-actions-importer/security/code-scanning/3