Conversation
Update the Go OpenTelemetry landing page and shared setup snippets to prefer OTLP export over the deprecated span processor integration. Document the direct-to-Sentry exporter path and the collector-based path so Go users have a clear migration target. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Replace non-existent NewErrorLinkingIntegration() with the actual exported function sentryotel.NewOtelIntegration() throughout the OTLP migration docs. Co-Authored-By: claude-sonnet-4-6 <noreply@anthropic.com>
| TracesSampleRate: 1.0, | ||
| Debug: true, | ||
| Integrations: func(integrations []sentry.Integration) []sentry.Integration { | ||
| return append(integrations, sentryotel.NewOtelIntegration()) |
There was a problem hiding this comment.
Bug: The Go OTLP setup documentation omits instructions for configuring a standard OpenTelemetry propagator, which will break distributed tracing for users following the guide.
Severity: HIGH
Suggested Fix
Update the Go OTLP setup documentation to include an example of how to configure a standard OpenTelemetry propagator, such as otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})). Explain that this is required for distributed tracing to work with OTLP.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: platform-includes/performance/opentelemetry-setup/go.mdx#L22
Potential issue: The updated Go documentation for OpenTelemetry setup removes the
previous Sentry-specific propagator configuration but does not replace it with
instructions for setting up a standard OpenTelemetry propagator, such as
`propagation.TraceContext{}`. Users following this guide will have an incomplete setup,
causing distributed tracing across services to fail because trace context will not be
propagated. The OTLP integration specification explicitly delegates propagator setup to
documentation, a responsibility this update fails to meet.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Update the Go OpenTelemetry docs to reflect the migration away from the deprecated span processor setup and toward OTLP.
This updates the landing page and shared Go snippets to:
sentryotlp.NewTraceExporter()for direct-to-Sentry tracingsentryotel.NewErrorLinkingIntegration()for linking Sentry errors to OTel tracesIS YOUR CHANGE URGENT?
SLA
PRE-MERGE CHECKLIST