Remove dummy DCO workflow for the merge queue#605
Draft
llucax wants to merge 5 commits into
Draft
Conversation
The DCO GitHub App now runs on merge queue (merge_group) events, so the "DCO" required status check no longer needs to accept a status from any integration. Pin it to the DCO GitHub App (integration_id 1861) in the "Protect version branches" ruleset exports. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The DCO GitHub App did not use to run on merge queue (merge_group) events, so a dummy workflow provided a passing "DCO" status check to satisfy the required check when merging through the queue. The DCO app now runs on merge_group events, making the dummy workflow obsolete, so drop it from the template and regenerate all affected golden fixtures. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Mirror the template and ruleset changes so existing repositories pick them up too. Add two migration steps: one removes the obsolete `.github/workflows/dco-merge-queue.yml` workflow, and one pins the "DCO" required status check in the "Protect version branches" ruleset to the DCO GitHub App (`integration_id` 1861) via the `gh` CLI. Both are idempotent and report a manual step when the change cannot be applied automatically. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
Bot
added
the
part:template
Contributor
Author
|
Draft because it seems the upstream fix is still not working properly. See: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DCO GitHub App now runs on merge queue (
merge_group) events, so the "DCO" required status check no longer needs to accept a status from any integration and we don't need to ship a dummy workflow to run in the merge queue just to satisfy the DCO check.Fixes #277 and #604.