fix(admin): allow relative URLs in menu custom links#316
Open
mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix(admin): allow relative URLs in menu custom links#316mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
mvanhorn wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
The URL input used HTML5 type="url" which requires a full URL with scheme, rejecting relative paths like /about. Changed to type="text" since the backend already accepts any string for customUrl. Fixes emdash-cms#155 This contribution was developed with AI assistance (Codex).
🦋 Changeset detectedLatest commit: 0703f19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the menu editor's URL input from
type="url"totype="text"so relative paths like/aboutand/contactare accepted. The starter templates ship with relative links in seeded menu data, but users couldn't add their own because browser validation rejected non-absolute URLs.The backend schema (
packages/core/src/api/schemas/menus.ts) already accepts any string forcustomUrl, so this is purely a frontend validation issue.Closes #155
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Details
Two inputs in
packages/admin/src/components/MenuEditor.tsxused HTML5type="url":HTML5
type="url"requires a full URL with scheme (https://...). Relative paths (/about,/contact,#section) fail browser validation. Changed both totype="text"and updated the placeholder to indicate relative paths are accepted.This contribution was developed with AI assistance (Codex).