Skip to content

fix: allow CLI help without config#4150

Open
Saithej2k wants to merge 1 commit into
elastic:mainfrom
Saithej2k:fix/help-without-cli-config-v2
Open

fix: allow CLI help without config#4150
Saithej2k wants to merge 1 commit into
elastic:mainfrom
Saithej2k:fix/help-without-cli-config-v2

Conversation

@Saithej2k

Copy link
Copy Markdown

Summary

  • Defer configuration loading until a leaf command is invoked.
  • Allow top-level, group, and nested command help without a local config file.
  • Cover every connector, index, and job help route.

Context

Follow-up to #4109. This addresses the review finding that parent group callbacks loaded config before Click processed a leaf command help option. The unused parent-context help check is removed.

Testing

  • 53 CLI tests passed
  • Ruff passed for the changed source and test files
  • git diff --check

@Jan-Kazlouski-elastic Jan-Kazlouski-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Saithej2k
Changes look good.
A few small suggestions to take care of and we'll be good to merge it!
Would you please address these?

Comment thread app/connectors_service/connectors/connectors_cli.py Outdated
Comment thread app/connectors_service/connectors/connectors_cli.py Outdated
Comment thread app/connectors_service/tests/test_connectors_cli.py
Comment thread app/connectors_service/connectors/connectors_cli.py
@Saithej2k
Saithej2k force-pushed the fix/help-without-cli-config-v2 branch from aff8f5e to 0384135 Compare July 10, 2026 16:01
@Jan-Kazlouski-elastic

Copy link
Copy Markdown
Contributor

buildkite test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants