fix: allow CLI group help without config#4109
Conversation
|
💚 CLA has been signed |
|
Hello @Saithej2k |
935c8a5 to
aca9070
Compare
|
buildkite test this |
aca9070 to
5601c24
Compare
|
buildkite build this |
5601c24 to
3c03766
Compare
|
buildkite build this |
Jan-Kazlouski-elastic
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @Saithej2k! Unfortunately this only fixes <group> --help — nested help like connectors job start --help still fails, since the group callback runs ensure_config before Click processes the leaf command's --help. Also, is_help_request() is effectively dead code (ctx.args is empty in the parent callback, so it always returns False).
|
Thanks for the review. I addressed both points in #4150: configuration now loads only when a leaf command callback runs, and the tests cover every nested help route, including job start --help. I opened the corrected change as a focused follow-up because this PR was already closed. |
Summary
connectors job --help.connectors login.Testing
git diff --checkCloses #3700