Azure Split - Step 4 - Cleanup#3917
Open
paulmedynski wants to merge 36 commits intodev/paul/azure/step3from
Open
Azure Split - Step 4 - Cleanup#3917paulmedynski wants to merge 36 commits intodev/paul/azure/step3from
paulmedynski wants to merge 36 commits intodev/paul/azure/step3from
Conversation
Make all of the common changes that aren't directly related to the Azure Split work, but set the stage for it and will make subsequent PRs much easier to consume.
- Added a few more changes.
- Fixed compilation issues.
- Fixed missing referenceType parameter.
- Fixed another missing referenceType.
- Fixed buildConfiguration parameter name.
- Removed non-existent projects from CodeQL Workflow.
- Tweaks after reviewing the PR.
- Fixed Windows .NET compilation issue.
- Fixed packages/ dir creation.
- Fixed missing MDS package version during Package builds.
- Generating MDS NuGet package for subsequent AKV build in Package mode.
- Running Release build for Debug pipelines in Project mode to avoid NuGet packaging issues.
- Restoring default mdsPackageVersion for Project based runs.
- Restoring inhibition of NuGet package generation.
- Added the new Abstractions and Azure source files and associated pipeline files. - Setup build.proj targets and default version numbers. - Standardized project CLS compliance.
- Added ThisAssembly generation to Abstractions. - Fixed branch wildcards in PR pipeline and CodeQL workflow triggers.
- Fixed paratemer name typo.
- Fixed cyclic dependency.
- Inhibited some Azure tests that won't pass yet. - Addressed Copilot comments in the PR.
- Addressed Copilot suggestions.
…ogether - Brought over all of the remaining code and project changes.
…ogether - Brought over the pipeline changes. - Removed unnecessary flexibility from the MDS official pipeline tree.
…ogether - Removed Azure parameters from CI test tree.
…ogether - Fixed missing Abstractions and MDS package version parameters.
…ogether - Re-activate the Azure tests. - Address PR comments.
This was referenced Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Final cleanup pass for the Azure split work, focusing on small code tidy-ups and pipeline/template adjustments for Azure/AKV/signing/PR validation.
Changes:
- Minor test/source cleanup (namespace alignment, formatting, retry-after millisecond conversion).
- Pipeline/template refactors to consolidate
.NET SDKinstallation and simplify signing/package validation steps. - Updates to PR validation and CodeQL trigger configuration.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlAuthenticationProviderManagerTests.cs | Aligns unit test namespace/formatting with the rest of the UnitTests tree. |
| src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs | Adds XML docs for Empty() (currently attached to the wrong symbol). |
| src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs | Fixes retry-after delta conversion to use total milliseconds; whitespace cleanup. |
| src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs | Formatting-only change for ternary expression. |
| eng/pipelines/steps/compound-build-akv-step.yml | Removes redundant SDK install step from the AKV compound step. |
| eng/pipelines/sqlclient-pr-project-ref-pipeline.yml | Adjusts PR branch include pattern for dev/*. |
| eng/pipelines/sqlclient-pr-package-ref-pipeline.yml | Adjusts PR branch include pattern for dev/*. |
| eng/pipelines/jobs/test-azure-package-ci-job.yml | YAML formatting cleanup (folded block style) for debug output step. |
| eng/pipelines/jobs/build-akv-official-job.yml | Adds explicit .NET SDK install before AKV build/analyzers. |
| eng/pipelines/dotnet-sqlclient-signing-pipeline.yml | Updates artifact folder naming and simplifies validation job invocation. |
| eng/pipelines/common/templates/steps/code-analyze-step.yml | Changes analyzer MSBuild invocation to explicitly target BuildAllConfigurations. |
| eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml | Removes redundant SDK install from this step template. |
| eng/pipelines/common/templates/jobs/validate-signed-package-job.yml | Simplifies parameters and inlines the artifact download step. |
| eng/pipelines/common/templates/jobs/build-signed-package-job.yml | Switches to pwsh, installs SDK, passes Abstractions version property, and sets build-type output variable (currently broken). |
| .github/workflows/codeql.yml | Updates CodeQL triggers/comments (push trigger now unscoped). |
src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/paul/azure/step3 #3917 +/- ##
========================================================
+ Coverage 67.41% 67.43% +0.02%
========================================================
Files 260 260
Lines 65691 65691
========================================================
+ Hits 44284 44300 +16
+ Misses 21407 21391 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
force-pushed
the
dev/paul/azure/step3
branch
from
25590be to
ad7ea2f
Compare
mdaigle
requested changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
This log message is incorrectly using ex.FailureCode for the timeout value in the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes any remaining cleanup:
PR series:
Testing