Azure Split - Step 3 - Tie Everything Together #3908

paulmedynski · 2026-01-22T15:41:03Z

Description

This PR ties everything together:

Removes Azure authentication files from the MDS projects.
Adds dependencies to the Abstractions package everywhere necessary.
Updates pipelines to include Abstractions and Azure packages where necessary.
Removed some unnecessary flexibility in the MDS official pipeline.

PR series:

Azure Split - Step 1 - Prep Work #3902:
- Merge changes that aren't directly related to the Azure split work, but that setup the stage for that work.
Azure Split - Step 2 - New Files #3904:
- Merge new files and related changes that do not affect the existing MDS projects or artifacts.
Azure Split - Step 3 - Tie Everything Together #3908:
- Merge the changes to MDS and pipelines that tie everything together.
Azure Split - Step 4 - Cleanup #3917:
- Any remaining tasks or cleanup.

Testing

Normal PR/CI pipeline runs will validate most changes.
Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

Copilot

Pull request overview

This pull request is the third step in the Azure Split work, which removes Azure authentication implementation from the main SqlClient project and establishes dependencies on the new Abstractions package. The PR removes Azure-specific authentication code, updates project dependencies, adds test authentication providers, and updates CI/CD pipelines to handle the new package structure.

Changes:

Removes ActiveDirectoryAuthenticationProvider, SqlAuthenticationProvider, SqlAuthenticationToken, SqlAuthenticationParameters, and related Azure authentication classes from the MDS source
Adds dependency on Microsoft.Data.SqlClient.Extensions.Abstractions package across all MDS projects (src and ref)
Updates test infrastructure with UsernamePasswordProvider and ManagedIdentityProvider implementations for manual tests
Updates all pipeline YAML files to include AbstractionsPackageVersion parameter and propagate it through build and test steps

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/specs/Microsoft.Data.SqlClient.nuspec	Adds Abstractions package dependency to all target frameworks
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs	Implements dynamic loading of Azure extension package as default provider
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs	Refactors token acquisition retry logic to use new exception model
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/*.cs	Adds test authentication providers
src/Microsoft.Data.SqlClient/**/Microsoft.Data.SqlClient.csproj	Removes Azure.* package references, adds Abstractions reference
eng/pipelines/*/.yml	Adds AbstractionsPackageVersion parameter throughout

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/UsernamePasswordProvider.cs

Copilot

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated no new comments.

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

codecov · 2026-01-23T11:56:15Z

Codecov Report

❌ Patch coverage is 51.81347% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.41%. Comparing base (30140f6) to head (25590be).

Files with missing lines	Patch %	Lines
...Data/SqlClient/SqlAuthenticationProviderManager.cs	43.39%	60 Missing ⚠️
...Data/SqlClient/Connection/SqlConnectionInternal.cs	51.61%	15 Missing ⚠️
...ta/SqlClient/SqlAuthenticationParametersBuilder.cs	77.55%	11 Missing ⚠️
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           dev/paul/azure/step2    #3908      +/-   ##
========================================================
- Coverage                 67.54%   67.41%   -0.14%     
========================================================
  Files                       263      260       -3     
  Lines                     66190    65691     -499     
========================================================
- Hits                      44710    44284     -426     
+ Misses                    21480    21407      -73

Flag	Coverage Δ
netcore	`67.48% <48.70%> (-0.07%)`	⬇️
netfx	`66.38% <51.81%> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 2 comments.

....SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlAuthenticationProviderManagerTests.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

…ogether - Brought over all of the remaining code and project changes.

…ogether - Brought over the pipeline changes. - Removed unnecessary flexibility from the MDS official pipeline tree.

…ogether - Removed Azure parameters from CI test tree.

…ogether - Fixed missing Abstractions and MDS package version parameters.

…ogether - Re-activate the Azure tests. - Address PR comments.

…ogether - Addressed a few final comments from the Step 2 PR.

eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

eng/pipelines/common/templates/steps/publish-symbols-step.yml

eng/pipelines/common/templates/steps/run-all-tests-step.yml

src/Microsoft.Data.SqlClient.Extensions/Abstractions/README.md

src/Microsoft.Data.SqlClient.Extensions/Azure/test/WorkloadIdentityFederationTests.cs

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

mdaigle · 2026-02-02T21:04:04Z

eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml

The name of this file (and its netfx equivalent) is generic enough that I wouldn't expect it to be locked down to Release and Package. I'm ok with this change, but would like to change the file names to better set expectations.

Ideally these are going to be blown away with the new pipeline, post this and common mds project work.

The official templates and CI/PR templates are all mushed together. I've been adding comments to the tops of the official ones to help us out until we can create the new pipelines, which IMO should have their own directories to keep things obviously separate.

mdaigle · 2026-02-02T21:07:12Z

eng/pipelines/common/templates/steps/copy-dlls-for-test-step.yml

Likewise, this file is package ref specific, but the name doesn't convey that.

mdaigle · 2026-02-02T21:09:49Z

eng/pipelines/dotnet-sqlclient-ci-core.yml

        dependsOn:
          - build_abstractions_package_stage
          - build_mds_akv_packages_stage
+      dotnetVerbosity: diagnostic


Set back to normal?

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlAuthenticationProviderManagerTests.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

benrr101

Overall looks good to me 🚢

benrr101 · 2026-02-02T23:58:54Z

build.proj

        $(DotnetPath)dotnet test "@(UnitTestsProj)"
        -f $(TF)
        -p:Configuration=$(Configuration)
+        -p:ReferenceType=Project


Seems a bit unnecessary/misleading to me to have this - the unit test csproj doesn't pay any attention to the reference type, unless there's some magic junk going on in the directory.build.props (and if there is, we should remove it)

This is one of those times that the absence of ReferenceType looks weird (because it is needed everywhere else), and its presence looks weird (if you know that UnitTests doesn't explicitly need it). The src/Directory.Build.props does use it, but it applies a default of Project, so you're correct that it isn't strictly needed here. I will remove this and add a comment explaining why it is absent.

benrr101 · 2026-02-03T00:06:52Z

build.proj

        -p:Configuration=$(Configuration)
        -p:ReferenceType=$(ReferenceType)
+        -p:AbstractionsPackageVersion=$(AbstractionsPackageVersion)
+        -p:MdsPackageVersion=$(MdsPackageVersion)


Don't get caught by the same gotcha that I did - make sure these either have a default value (in build.proj) or are conditionally included. Otherwise, they'll get permanently set to "".

They have defaults brought in by src/Directory.Build.props -> Versions.props.

benrr101 · 2026-02-03T00:12:38Z

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

+  # If we're testing in Package mode, we have a few additional steps.
  - ${{ if eq(parameters.referenceType, 'Package') }}:
+
+    # Create the packages/ directory.


Maybe I'm reversing course here... but maybe rather than this course, we just have the packages directory with a .gitkeep file in it or a readme that explains that what it's for?

I think you're correct - let's just ensure this directory always exists in the repo.

benrr101 · 2026-02-03T00:15:21Z

eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml

Ideally these are going to be blown away with the new pipeline, post this and common mds project work.

…ogether - Fixed missing ;

- Trying to fix test filters.

…ntains spaces and special characters.

…ogether - Addressed PR comments/suggestions.

Copilot

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-04T12:16:55Z

packages/.gitkeep

+# This directory must exist in order for NuGet restores to succeed prior to # our builds generating
+# any NuGet package files here.


The comment text here looks malformed: # This directory must exist in order for NuGet restores to succeed prior to # our builds generating contains an extra # and reads awkwardly. Please update it to a grammatically correct sentence (for example, remove the stray # and merge the two lines into a single clear sentence) so the intent of the comment is unambiguous.

Suggested change

# This directory must exist in order for NuGet restores to succeed prior to # our builds generating

# any NuGet package files here.

# This directory must exist so that NuGet restores succeed before our builds generate any NuGet package files here.

eng/pipelines/common/templates/steps/override-sni-version.yml

paulmedynski · 2026-02-04T11:18:02Z

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

-    public class AADConnectionsTest
+    public class AADConnectionTest
    {
-        class CustomSqlAuthenticationProvider : SqlAuthenticationProvider


This helper became UsernamePasswordProvider in DataCommon.

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

paulmedynski · 2026-02-04T11:22:28Z

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

-            // Clear token cache for code coverage.
-            ActiveDirectoryAuthenticationProvider.ClearUserTokenCache();
-            using (SqlConnection connection = new SqlConnection(DataTestUtility.AADPasswordConnectionString))
+            #pragma warning disable 0618 // Type or member is obsolete


These blocks are an attempt to cleanup the global state and improve test reliability.

paulmedynski · 2026-02-04T11:26:12Z

build.proj

        $(DotnetPath)dotnet test "@(UnitTestsProj)"
        -f $(TF)
        -p:Configuration=$(Configuration)
+        -p:ReferenceType=Project


This is one of those times that the absence of ReferenceType looks weird (because it is needed everywhere else), and its presence looks weird (if you know that UnitTests doesn't explicitly need it). The src/Directory.Build.props does use it, but it applies a default of Project, so you're correct that it isn't strictly needed here. I will remove this and add a comment explaining why it is absent.

paulmedynski · 2026-02-04T11:30:07Z

build.proj

        -p:Configuration=$(Configuration)
        -p:ReferenceType=$(ReferenceType)
+        -p:AbstractionsPackageVersion=$(AbstractionsPackageVersion)
+        -p:MdsPackageVersion=$(MdsPackageVersion)


They have defaults brought in by src/Directory.Build.props -> Versions.props.

paulmedynski · 2026-02-04T11:31:29Z

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

+  # If we're testing in Package mode, we have a few additional steps.
  - ${{ if eq(parameters.referenceType, 'Package') }}:
+
+    # Create the packages/ directory.


I think you're correct - let's just ensure this directory always exists in the repo.

…ogether - Addressed Copilot feedback.

Copilot

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

tools/specs/Microsoft.Data.SqlClient.nuspec

…ogether - Addressed Copilot review comments.

mdaigle · 2026-02-04T17:03:42Z

NuGet.config

+      packages that are not available on the public nuget.org feed, for example to test MDS that
+      depends on a version of Abstractions that was just built in the workspace.
+    -->
+    <add key="local" value="packages/" />


I have a pretty strong preference against this approach. I think this will make it too easy to accidentally build and test against local artifacts when we mean to test against public ones. At any point, something could end up in the packages directory unexpectedly and it would be used without any indication or opt-in.

We can pass in the nuget file to use on the dotnet restore calls using the --configfile option: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-restore

…ogether - Now using reference type to choose NuGet config file.

Copilot

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADAuthenticationTests.cs

…ogether - Fixed Azure build command lines.

…ogether - Added missing reference type to AKV restore targets.

paulmedynski added this to the 7.0.0-preview4 milestone Jan 22, 2026

paulmedynski added the Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity. label Jan 22, 2026

Copilot AI review requested due to automatic review settings January 22, 2026 15:41

This was referenced Jan 22, 2026

Azure Split - Step 2 - New Files #3904

Merged

Azure Split - Step 1 - Prep Work #3902

Merged

Copilot started reviewing on behalf of paulmedynski January 22, 2026 15:41 View session

paulmedynski mentioned this pull request Jan 22, 2026

[DO NOT MERGE] Visuazlie diffs of feat/azure split #3901

Closed

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 16:26

Copilot started reviewing on behalf of paulmedynski January 22, 2026 16:27 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

edwardneal reviewed Jan 22, 2026

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs Outdated Show resolved Hide resolved

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs Show resolved Hide resolved

paulmedynski marked this pull request as ready for review January 26, 2026 15:41

paulmedynski requested a review from a team as a code owner January 26, 2026 15:41

Copilot AI review requested due to automatic review settings January 26, 2026 15:41

paulmedynski changed the title ~~[Draft] Azure Split - Step 3 - Tie Everything Together~~ Azure Split - Step 3 - Tie Everything Together Jan 26, 2026

Copilot started reviewing on behalf of paulmedynski January 26, 2026 15:41 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

....SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlAuthenticationProviderManagerTests.cs Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Show resolved Hide resolved

paulmedynski mentioned this pull request Jan 27, 2026

Azure Split - Step 4 - Cleanup #3917

Open

paulmedynski force-pushed the dev/paul/azure/step2 branch from 30140f6 to 18ac28b Compare January 29, 2026 19:07

priyankatiwari08 self-assigned this Feb 2, 2026

Base automatically changed from dev/paul/azure/step2 to main February 2, 2026 19:32

paulmedynski added 6 commits February 2, 2026 15:35

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

1f11388

…ogether - Brought over all of the remaining code and project changes.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

bf0b91a

…ogether - Brought over the pipeline changes. - Removed unnecessary flexibility from the MDS official pipeline tree.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

af49e59

…ogether - Removed Azure parameters from CI test tree.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

dbb1e15

…ogether - Fixed missing Abstractions and MDS package version parameters.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

313e26a

…ogether - Re-activate the Azure tests. - Address PR comments.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

ad7ea2f

…ogether - Addressed a few final comments from the Step 2 PR.

Copilot AI review requested due to automatic review settings February 2, 2026 19:41

paulmedynski force-pushed the dev/paul/azure/step3 branch from 25590be to ad7ea2f Compare February 2, 2026 19:41

paulmedynski commented Feb 2, 2026

View reviewed changes

Copilot AI reviewed Feb 2, 2026

View reviewed changes

mdaigle requested changes Feb 2, 2026

View reviewed changes

benrr101 previously approved these changes Feb 3, 2026

View reviewed changes

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

19c0963

…ogether - Fixed missing ;

paulmedynski dismissed benrr101’s stale review via 19c0963 February 3, 2026 12:42

paulmedynski added 3 commits February 3, 2026 09:50

- Fixed missing SNI DLLs for .NET Framework in Project reference tests.

86f06f6

- Trying to fix test filters.

Trying to fix test filters with quoted filter expression, since it co…

eac8d45

…ntains spaces and special characters.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

1544e3c

…ogether - Addressed PR comments/suggestions.

Copilot AI review requested due to automatic review settings February 4, 2026 12:09

Copilot started reviewing on behalf of paulmedynski February 4, 2026 12:10 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

paulmedynski commented Feb 4, 2026

View reviewed changes

paulmedynski added 2 commits February 4, 2026 08:28

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

406aad1

…ogether - Addressed Copilot feedback.

Merge branch 'main' into dev/paul/azure/step3

48fa3a9

Copilot AI review requested due to automatic review settings February 4, 2026 14:36

Copilot started reviewing on behalf of paulmedynski February 4, 2026 14:36 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

tools/specs/Microsoft.Data.SqlClient.nuspec Show resolved Hide resolved

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

5685229

…ogether - Addressed Copilot review comments.

mdaigle requested changes Feb 4, 2026

View reviewed changes

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

df540b1

…ogether - Now using reference type to choose NuGet config file.

Copilot AI review requested due to automatic review settings February 4, 2026 18:18

Copilot started reviewing on behalf of paulmedynski February 4, 2026 18:18 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADAuthenticationTests.cs Show resolved Hide resolved

paulmedynski added 2 commits February 4, 2026 14:38

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

ef0a194

…ogether - Fixed Azure build command lines.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

4f9c47b

…ogether - Added missing reference type to AKV restore targets.

Copilot AI review requested due to automatic review settings February 4, 2026 19:37

Copilot started reviewing on behalf of paulmedynski February 4, 2026 19:37 View session

		# This directory must exist in order for NuGet restores to succeed prior to # our builds generating
		# any NuGet package files here.

	# This directory must exist in order for NuGet restores to succeed prior to # our builds generating
	# any NuGet package files here.
	# This directory must exist so that NuGet restores succeed before our builds generate any NuGet package files here.

Azure Split - Step 3 - Tie Everything Together #3908

Are you sure you want to change the base?

Azure Split - Step 3 - Tie Everything Together #3908

Conversation

paulmedynski commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benrr101 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

paulmedynski commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading