fix: Provide password hash to chpasswd instead - #107
Merged
Conversation
Current usage is broken because `usermod` is expecting the encrypted password as a value directly after `-p` flag. However, `chpasswd` also supports encrypted password so let's use a single tool and align syntaxes.
There was a problem hiding this comment.
Pull request overview
This PR fixes root password setup in the container entrypoint when an encrypted password hash is provided, switching to chpasswd -e so the hash is applied correctly (and consistently with the non-hash path).
Changes:
- Replace incorrect
usermod -pusage withchpasswd -ewhenPASSWORD_HASHis set. - Standardize password setting logic to use
chpasswdfor both plaintext and hashed inputs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kroese
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested.
Current usage is broken because
usermodis expecting the encrypted password as a value directly after-pflag.However,
chpasswdalso supports encrypted password so let's use a single tool and align syntaxes.