Skip to content

Support DomElastica refs on React 18 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aayush10016 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support DomElastica refs on React 18 #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions packages/react/src/dom/dom-elastica.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import Elastica, {
} from '@darkroom.engineering/elastica'
import { useFrame, useRect } from '@darkroom.engineering/hamo'
import {
forwardRef,
useCallback,
useEffect,
useImperativeHandle,
useMemo,
useRef,
useState,
type ReactNode,
type Ref,
type RefObject,
} from 'react'
import { ElasticaContext, type DomElasticaContextValue } from '../context'
Expand All @@ -35,7 +35,6 @@ export type DomElasticaProps = {
initialCondition?: (params: InitialConditionParams) => void
update?: (params: UpdateParams) => void
showHashGrid?: boolean
ref?: Ref<DomElasticaRef>
}

// Default config values
Expand Down Expand Up @@ -80,15 +79,18 @@ const DEFAULT_CONFIG: ElasticaConfigOBB = {
* ```
*/

export function DomElastica({
children,
className,
config,
initialCondition = () => {},
update = () => {},
showHashGrid = false,
ref,
}: DomElasticaProps) {
export const DomElastica = forwardRef<DomElasticaRef, DomElasticaProps>(
function DomElastica(
{
children,
className,
config,
initialCondition = () => {},
update = () => {},
showHashGrid = false,
},
ref
) {
const timeRef = useRef(0)
const isPausedRef = useRef(false)
const boxesRefs = useRef(new Map<HTMLElement, ElementData>())
Expand Down Expand Up @@ -256,4 +258,5 @@ export function DomElastica({
</ElasticaContext.Provider>
</div>
)
}
}
)