Support DomElastica refs on React 18#28
Open
Aayush10016 wants to merge 1 commit into
Open
Conversation
|
@Aayush10016 is attempting to deploy a commit to the Darkroom Team on Vercel. A member of the Team first needs to authorize it. |
Aayush10016
marked this pull request as ready for review
July 24, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
What changed
DomElasticawithforwardRef.DomElasticaRefimperative API forplay()andpause().reffromDomElasticaPropsso React handles it as a real ref instead of a normal prop.Why
The package allows React
>=18.2, but plain function componentrefprops only work with React 19 behavior. In React 18, the ref is not delivered toDomElasticaas a normal prop, so the imperativeplay()andpause()handle cannot be used reliably.Using
forwardRefpreserves React 18 support without requiring a peer dependency bump.Validation
node_modules\.bin\tsc.cmd -p packages\react\tsconfig.json --noEmitnpm --prefix packages\react run build