Skip to content

Add globals#137

Closed
DavisVaughan wants to merge 1 commit intodark-peak-analytics:mainfrom
DavisVaughan:fix/dplyr
Closed

Add globals#137
DavisVaughan wants to merge 1 commit intodark-peak-analytics:mainfrom
DavisVaughan:fix/dplyr

Conversation

@DavisVaughan
Copy link
Copy Markdown

Hi there, we are working on the next version of dplyr and your package was flagged in our reverse dependency checks.

We have removed the defunct function dplyr::location().

Your package does one of two things:

  • It re-exports dplyr::location(), which has been defunct for many years and has now been removed from dplyr.

  • It references a column named location, likely in a mutate() or summarise(), but does not note this as a global variable with utils::globalVariables("location"). In this case, you got lucky that dplyr exported location(), meaning that you did not need a global variable for "location". Since we have removed dplyr::location(), your package will need this now.

dplyr will be released on January 31, 2026. If you could please send an update of your package to CRAN before then, that would help us out a lot! Thanks!

@RobertASmith
Copy link
Copy Markdown
Contributor

RobertASmith commented Jan 18, 2026

@W-Mohammed could you investigate - think it's as simple as changing "location" to another column name in the code.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@W-Mohammed
Copy link
Copy Markdown
Collaborator

Documented in #141. Closing this PR as we are fixing the described here in #142.

@W-Mohammed W-Mohammed closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants