Skip to content

RFC 016/018/024 wave 1 function catalog foundations#44

Merged
dannymeijer merged 8 commits into
mainfrom
feature/33-35-41-wave1-function-catalog
May 26, 2026
Merged

RFC 016/018/024 wave 1 function catalog foundations#44
dannymeijer merged 8 commits into
mainfrom
feature/33-35-41-wave1-function-catalog

Conversation

@dannymeijer
Copy link
Copy Markdown
Collaborator

Summary

This is the base PR for the function-catalog stack.

  • RFC 016: add registry-backed core aggregate helpers for avg, min, and max; preserve sum/count(); add count_expr(expr) as the expression-count compatibility path.
  • RFC 018: add a narrow common scalar math slice: abs, ceil, floor, and round.
  • RFC 024: add function policy/namespace metadata for portable core, extension-only, compatibility alias, engine-specific, and rejected categories.
  • Update Substrait function-extension lowering, aggregate relation lowering, registry inspection helpers, docs, and session tests.

Count expression note

The current decorator/static metadata lowering does not yet support an exact decorated helper spelling for both count() and count(expr). I tested default-argument and variadic decorated helper shapes; both failed at compile/lowering boundaries. This PR keeps count() canonical and exposes count_expr(expr) as a compatibility helper that lowers through canonical Substrait count metadata.

Verification

  • make fmt
  • make fmt-check
  • make test-style
  • make registry-metadata
  • make build
  • make test
  • make smoke-consumer
  • make pre-commit

Refs #33
Refs #35
Refs #41

@dannymeijer dannymeijer self-assigned this May 26, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in @Incan May 26, 2026
@dannymeijer dannymeijer removed this from @Incan May 26, 2026
@dannymeijer dannymeijer added this to the InQL-v0.1 milestone May 26, 2026
@dannymeijer dannymeijer marked this pull request as ready for review May 26, 2026 20:18
@dannymeijer dannymeijer merged commit 349e8e9 into main May 26, 2026
4 checks passed
@dannymeijer dannymeijer deleted the feature/33-35-41-wave1-function-catalog branch May 26, 2026 20:36
@dannymeijer dannymeijer added this to @InQL Jun 2, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in @InQL Jun 2, 2026
@github-project-automation github-project-automation Bot moved this to Todo in @InQL Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant