feature - implement RFC 021 generator table functions (#38)#47
Merged
Conversation
This was referenced May 25, 2026
Merged
76cdb21 to
3a03dd1
Compare
bbe913e to
959e82e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements RFC 021 generator and table-valued functions after RFC 020 has merged into
main. This PR adds the full portable generator surface forexplode,explode_outer,posexplode,posexplode_outer,inline,inline_outer,flatten, andstack, keeping generators distinct from scalar expressions and aggregate measures while lowering them through Substrait relation-extension metadata.Refs #38.
Stack order: #44, #45, and #46 are merged; this PR targets current
maindirectly.Type of change
docs/rfcs/*)Area(s)
Key details
generate(...)plus generator helpers forexplode(...),explode_outer(...),posexplode(...),posexplode_outer(...),inline(...),inline_outer(...), portable table-valuedflatten(...), andstack(...). Generated aliases are explicit and validated. The zero-argDataSet.explode()remains a lower-level extension-boundary operation rather than the RFC 021 generator surface.GeneratorApplication, generator registry metadata, PrismGeneratenodes, payload-backed Substrait relation-extension lowering, generator-aware output-column inference, and DataFusion execution for root and composed generator plans.GeneratorApplicationmodel.Testing / verification
make fmt INCAN=/Users/danny/Development/encero/incan/target/debug/incanincan test tests/test_session_generators.incn(10 passed)incan test tests(143 passed)make fmt-check INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake test-style INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake registry-metadata INCAN=/Users/danny/Development/encero/incan/target/debug/incan(87 helpers)make build INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake test INCAN=/Users/danny/Development/encero/incan/target/debug/incan(143 passed)make smoke-consumer INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake pre-commit INCAN=/Users/danny/Development/encero/incan/target/debug/incan(143 passed)git diff --check*_extension_uri()helper call sites insrc,tests, ordocsDocs impact
If docs updated:
docs/language/reference/functions/generators.md,docs/language/reference/functions/nested.md,docs/language/reference/dataset_methods.md,docs/rfcs/021_generator_table_functions.md,docs/release_notes/v0_1.mdChecklist