Skip to content

Fixes Docblock class ClientTokenGateway and PayPalAccountGateway #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BruceGitHub wants to merge 2 commits into from
Closed

Fixes Docblock class ClientTokenGateway and PayPalAccountGateway #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7667464
Fixes Docblock class ClientTokenGateway
BruceGitHub Mar 4, 2022
5e5367c
Fixes Docblock PayPalAccountGateway mehtod _validateId
BruceGitHub Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Braintree/ClientTokenGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function __construct($gateway)
/**
* Generate a client token for client-side authorization
*
* @param Optional $params containing request parameters
* @param $params Optional, containing request parameters
Copy link
Copy Markdown

@ElonSmithee ElonSmithee May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param $params Optional, containing request parameters
* @param mixed $params Optional, containing request parameters

Copy link
Copy Markdown
Author

@BruceGitHub BruceGitHub May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me no problem, but why mixed ?

Copy link
Copy Markdown

@Synchro Synchro Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this one too. It should be array. As it stands, phpstan is looking for a class called Braintree\Optional.

*
* @return string client token
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Braintree/PayPalAccountGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ private function _verifyGatewayResponse($response)
* verifies that a valid paypal account identifier is being used
*
* @param string $identifier
* @param Optional $string $identifierType type of identifier supplied, default 'token'
* @param string $identifierType Optional, type of identifier supplied, default 'token'
*
* @throws InvalidArgumentException
*/
Expand Down