Fixes Docblock class ClientTokenGateway and PayPalAccountGateway#315
Closed
BruceGitHub wants to merge 2 commits intobraintree:masterfrom
BruceGitHub:fix-docblock-client-token-gateway-class
Closed
Fixes Docblock class ClientTokenGateway and PayPalAccountGateway#315BruceGitHub wants to merge 2 commits intobraintree:masterfrom BruceGitHub:fix-docblock-client-token-gateway-class
BruceGitHub wants to merge 2 commits intobraintree:masterfrom
BruceGitHub:fix-docblock-client-token-gateway-class
Conversation
BruceGitHub
changed the title
Contributor
|
🙃 thanks for the PR @BruceGitHub, no ETA but we will take a look and provide feedback or just merge. |
Open
ElonSmithee
reviewed
May 18, 2022
| * Generate a client token for client-side authorization | ||
| * | ||
| * @param Optional $params containing request parameters | ||
| * @param $params Optional, containing request parameters |
There was a problem hiding this comment.
Suggested change
| * @param $params Optional, containing request parameters | |
| * @param mixed $params Optional, containing request parameters |
Author
There was a problem hiding this comment.
For me no problem, but why mixed ?
There was a problem hiding this comment.
I just ran into this one too. It should be array. As it stands, phpstan is looking for a class called Braintree\Optional.
Contributor
|
hey folks, we'll take a look and provide feedback. for braintree folks, ticket 2046 |
hollabaq86
pushed a commit
that referenced
this pull request
Jan 11, 2023
* update dockerfile and composer file to versions of php and phpunit that will run in CI * setUp and teardown must be void compatible * fixup warning unit tests * address phpunit deprecation warnings * make integration tests setUp void compatible * fix breaking changes in integration tests * update tests to resolve deprecation warnings * Don't create phpunit cache file * add phpunit result cache to gitignore just in case * fixup SSL unit test * fixup failing integration tests
|
Please rewiew this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes format in Docblock classes: ClientTokenGateway and PayPalAccountGateway
Actual Docblock, cause an error for static analysis like Psalm, Phpstan because the class Optional does not exist actually