Skip to content

[PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection #21387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quexten merged 2 commits into from
Jun 19, 2026
Merged

[PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection #21387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8291e22
Fix IPC reset
quexten Jun 19, 2026
41c5d90
Eslint
quexten Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/desktop/src/services/native-messaging.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Injectable } from "@angular/core";

import { isForwardedIpcMessage, isIpcMessage } from "@bitwarden/common/platform/ipc";

import { LegacyMessageWrapper } from "../models/native-messaging/legacy-message-wrapper";
import { Message } from "../models/native-messaging/message";

Expand All @@ -19,6 +21,12 @@ export class NativeMessagingService {

private async messageHandler(msg: LegacyMessageWrapper | Message) {
const outerMessage = msg as Message;

// Ignore SDK IPC messages here
if (isIpcMessage(msg) || isForwardedIpcMessage(msg)) {
return;
}

if (outerMessage.version) {
// If there is a version, it is a using the protocol created for the DuckDuckGo integration
await this.duckduckgoMessageHandler.handleMessage(outerMessage);
Expand Down
Loading