[PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection#21387
Merged
Conversation
Contributor
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21387 +/- ##
==========================================
- Coverage 49.20% 49.20% -0.01%
==========================================
Files 4074 4074
Lines 127811 127814 +3
Branches 19565 19566 +1
==========================================
Hits 62891 62891
- Misses 60267 60270 +3
Partials 4653 4653 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mzieniukbw
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39295
📔 Objective
SDK IPC (and thus shared unlock, new biometric ipc) has a different message type, and is handled separately. Currently, the new IPC messages are making it into the legacy IPC services, and because those services don't understand the message type, this leads to an encryption reset loop where the service sees the message, and does not find an existing encryption set up for the connection, and resets the connection.
This PR fixes this by filtering out SDK ipc messages from making it to these services.
📸 Screenshots