Skip to content

[PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection#21387

Merged
quexten merged 2 commits into
mainfrom
km/fix-ipc-reset
Jun 19, 2026
Merged

[PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection#21387
quexten merged 2 commits into
mainfrom
km/fix-ipc-reset

Conversation

@quexten

@quexten quexten commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39295

📔 Objective

SDK IPC (and thus shared unlock, new biometric ipc) has a different message type, and is handled separately. Currently, the new IPC messages are making it into the legacy IPC services, and because those services don't understand the message type, this leads to an encryption reset loop where the service sees the message, and does not find an existing encryption set up for the connection, and resets the connection.

This PR fixes this by filtering out SDK ipc messages from making it to these services.

📸 Screenshots

@quexten quexten requested a review from mzieniukbw June 19, 2026 05:48
@quexten quexten changed the title Fix IPC reset [PM-39295] Fix IPC reset Jun 19, 2026
@quexten quexten marked this pull request as ready for review June 19, 2026 05:52
@quexten quexten requested a review from a team as a code owner June 19, 2026 05:52
@quexten quexten enabled auto-merge (squash) June 19, 2026 05:53
@github-actions

Copy link
Copy Markdown
Contributor

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@quexten quexten changed the title [PM-39295] Fix IPC reset [PM-39295] Fix SDK IPC messages being parsed by legacy IPC, resetting the connection Jun 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.20%. Comparing base (d8711f3) to head (41c5d90).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/desktop/src/services/native-messaging.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21387      +/-   ##
==========================================
- Coverage   49.20%   49.20%   -0.01%     
==========================================
  Files        4074     4074              
  Lines      127811   127814       +3     
  Branches    19565    19566       +1     
==========================================
  Hits        62891    62891              
- Misses      60267    60270       +3     
  Partials     4653     4653              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten merged commit c59ef9b into main Jun 19, 2026
88 of 90 checks passed
@quexten quexten deleted the km/fix-ipc-reset branch June 19, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants