Skip to content

Refactor mobile: getAppStrings to use execute_script exclusively #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 4 commits into
base: master
Choose a base branch
from
+1 −7
Open

Refactor mobile: getAppStrings to use execute_script exclusively #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74a9060
1.0.0
Mar 27, 2026
fe356e0
refactor: remove legacy fallback for `mobile: getAppStrings`
Dor-bl Apr 5, 2026
525c207
refactor: remove legacy fallback for `mobile: getAppStrings`
Dor-bl Apr 5, 2026
2025fdd
chore: add a blank line before version v5.2.7 in CHANGELOG.md
Dor-bl Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions appium/webdriver/extensions/applications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,7 @@ def app_strings(self, language: Union[str, None] = None, string_file: Union[str,
data['language'] = language
if string_file is not None:
data['stringFile'] = string_file
try:
return self.assert_extension_exists(ext_name).execute_script(ext_name, data)
except UnknownMethodException:
# TODO: Remove the fallback
return self.mark_extension_absence(ext_name).execute(Command.GET_APP_STRINGS, data)['value']
return self.assert_extension_exists(ext_name).execute_script(ext_name, data)

def _add_commands(self) -> None:
self.command_executor.add_command(Command.BACKGROUND, 'POST', '/session/$sessionId/appium/app/background')
Expand All @@ -271,4 +267,3 @@ def _add_commands(self) -> None:
'POST',
'/session/$sessionId/appium/device/app_state',
)
self.command_executor.add_command(Command.GET_APP_STRINGS, 'POST', '/session/$sessionId/appium/app/strings')
1 change: 0 additions & 1 deletion appium/webdriver/mobilecommand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class MobileCommand:
SWITCH_TO_CONTEXT = 'switchToContext'

BACKGROUND = 'background'
GET_APP_STRINGS = 'getAppStrings'

IS_LOCKED = 'isLocked'
LOCK = 'lock'
Expand Down
Loading