Refactor mobile: getAppStrings to use execute_script exclusively#1215
Open
Dor-bl wants to merge 4 commits intoappium:masterfrom
Open
Refactor mobile: getAppStrings to use execute_script exclusively#1215Dor-bl wants to merge 4 commits intoappium:masterfrom
Dor-bl wants to merge 4 commits intoappium:masterfrom
Conversation
This change removes the legacy fallback mechanism when executing `mobile: getAppStrings` in `appium/webdriver/extensions/applications.py`. The `app_strings` method now exclusively uses the `execute_script` approach. Correspondingly, the `GET_APP_STRINGS` command registration in `Applications._add_commands` and the command definition in `MobileCommand` have also been removed.
This change removes the legacy fallback mechanism when executing `mobile: getAppStrings` in `appium/webdriver/extensions/applications.py`. The `app_strings` method now exclusively uses the `execute_script` approach. Correspondingly, the `GET_APP_STRINGS` command registration in `Applications._add_commands` and the command definition in `MobileCommand` have also been removed.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how app string retrieval is handled in the Appium Python client by removing legacy code paths and cleaning up related commands. The primary focus is on simplifying the
app_stringsmethod and removing unused or deprecated command definitions.App string retrieval refactor:
app_stringsmethod inapplications.pyby removing the fallback to the legacyGET_APP_STRINGScommand and its associated exception handling. Now, only the extension-based approach is used.Command cleanup:
GET_APP_STRINGScommand from the command executor in_add_commands.GET_APP_STRINGSconstant fromMobileCommandinmobilecommand.py, as it is no longer used.