[ISSUE #381 #402] Add proxy fallback for gRPC consumer stats and request codes 106/206/208#418
Closed
itxaiohanglover wants to merge 1 commit into
Closed
Conversation
…ats and request codes 106/206/208 When dashboard connects to RocketMQ 5.x in proxy mode, several remoting request codes are not supported by the broker directly: - 106 GET_BROKER_CLUSTER_INFO - 206 GET_ALL_TOPIC_LIST_FROM_NAMESERVER - 208 GET_CONSUME_STATS Add getBrokerClusterInfo, getAllTopicListFromNameServer, and examineConsumeStats to ProxyAdmin/ProxyAdminImpl that send requests to the configured proxy address. Update ClusterServiceImpl, ClusterInfoService, TopicServiceImpl, and ConsumerServiceImpl to fall back to the proxy when standard mqAdminExt methods fail. This fixes: - apache#402: request type 106/206 not supported - apache#381: gRPC consumer latency showing -1 (consumeStats unavailable)
|
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381, fixes #402. Add proxy fallback for examineConsumeStats (208), getBrokerClusterInfo (106), and getAllTopicListFromNameServer (206) when standard mqAdminExt methods fail in proxy mode.